1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • src/sbbs3/answer.cpp

    From rswindell@1:103/705 to CVS commit on Tue Apr 7 19:14:03 2020
    src/sbbs3 answer.cpp 1.109 1.110
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20278

    Modified Files:
    answer.cpp
    Log Message:
    RLogin fix: if no username supplied, don't prompt for a password and then log an invalid login for a random (the last read?) user account with a user number of 0.

    --- SBBSecho 3.10-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Tue Apr 7 19:21:44 2020
    src/sbbs3 answer.cpp 1.110 1.111
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21452

    Modified Files:
    answer.cpp
    Log Message:
    Log the actual user number for "FAILED Password attempt" log messages for SSH and RLogin attempts.
    It looks like someone copy/pasted the wrong lines from login.cpp.

    --- SBBSecho 3.10-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Tue Apr 7 19:34:26 2020
    src/sbbs3 answer.cpp 1.111 1.112
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23193

    Modified Files:
    answer.cpp
    Log Message:
    Allow non-sysops a password re-attempt for SSH and RLogin.

    Fixed bug: for RLogin and SSH, if an invalid (e.g. blank) passsword was provided during the handshake, an "Invalid Logon" would be displayed followed by a "Passowrord: " prompt, giving the user an opportunity to reenter the correct password. Only problem: this only worked for sysop accounts. Normal users would just be disconnected after they entere (any) password, correct
    or not.

    This bug is very old in the RLogin support and appears to have been copy/pasted
    for the SSH Login bit too.

    --- SBBSecho 3.10-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Wed May 27 01:22:52 2020
    src/sbbs3 answer.cpp 1.113 1.114
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv29982

    Modified Files:
    answer.cpp
    Log Message:
    Include a non-zero info value for "User not loggon on" error message.

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Sat Aug 1 20:37:24 2020
    src/sbbs3 answer.cpp 1.115 1.116
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv24536

    Modified Files:
    answer.cpp
    Log Message:
    Fix typo (missing closing quote) in previous commit as pointed out by Coz via irc. Thanks.

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Wed Sep 16 20:37:29 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/52dc847cf6f0b569ec5f35e9
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Log message change: "Raw TCP" instead of "Raw/TCP" oooh.... ahhhh...
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Fri Oct 23 01:51:57 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/1a51ac2cf81b9497d52cb924
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    This "!CLIENT IP NOT LIST in /path/to/rlogin.cfg" message is weirdThis message can be logged when a sysop is prompted for the system password and enters it incorrectly or just disconnects.So lower the log level to DEBUG. And include the IP address that we searched for too.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Mon Nov 2 01:34:31 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/2df371fe01859b77a1c69afc
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Manual terminal settings were cleared when logging in via SSH or RLoginThis appears to go back to a change Deuce made in 2004 (rev 1.41) where ANSI, COLOR, RIP and WIP user terminal settings were always cleared when logging in via RLogin.I happened to notice that manually enabling iCE color support wasn't working when logging in via RLogin (the iCE color flag would be cleared every login, but worked fine when logging in via Telnet). Upon investigation, I found that *all* user's manual terminal settings were cleared for either RLogin or SSH logins (copy/pasted bug). So... stop doing that. The method of dynamic terminal capability detection/checking has changed since 2004, so we should not need to mess with the user's misc flags.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed Feb 10 21:18:22 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/838f67529b17611dd63d48b7
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Apply IP filters to address reported via Telnet Location commandFeature requested (?) by u/jumbotronjim on https://www.reddit.com/r/synchronet/:If the client connection is from a blocked IP address (in ip[-silent].can), but still manages to get through the web server and websocketservice and have their correct IP address reported via Telnet Location, terminate the connection. Seems dubious.
    --- SBBSecho 3.12-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Fri Dec 30 02:26:51 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/83c12ca4a34533e76ad6e080
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Don't try to send telnet commands if not connected.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Tue Jan 3 21:41:33 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c1d3b692a3959ca1fa8a5a91
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Write/publish node client terminal params after telnet cmd parsing
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Sun Sep 24 01:57:53 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/a292e8bbc95746429b05492b
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Hyphenate "sign-up" in log message
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Wed Dec 27 17:11:05 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/becf01f28860535195705e43
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Address new GCC build warning in new ssh related code

    comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wed Jan 17 17:37:50 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/8f9d12c3bca20ab46ef46954
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Whoops, missed this bit.

    Just running git commit --amend doesn't do -a it seems. :)
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Sat Jan 20 22:41:53 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/8998c57bd800a64ed4a03e6d
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Fix warning reported by nelgin.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Sat Jan 20 22:42:59 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3d0d1b91b6646943511dc134
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Actually fix warning reported by nelgin.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Sun Jan 21 01:13:24 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/fe62636c616af59b026c52cb
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Address GCC warning in SSH code

    328:25: warning: ‘pubkey’ may be used uninitialized
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Sun Jan 21 12:12:26 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/014cb781f152f5900c3f1e8c
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Fix pubkey-first auth attempts.

    Previously, once a pubkey was attempted, you could not use a password.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Jan 22 18:20:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/f8c7b04fd7165f58891de6bc
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Set client_socket to INVALID_SOCKET after closing.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Jan 22 18:24:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/208b7e794efc327ad1fce90e
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Actually, no real reason to close the socket here... let the caller
    handler it.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Feb 16 18:17:02 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/e4f92887e1ea3d53faf89152
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Log the auto-detected character set (e.g. UTF-8, CP437, PETSCII, or US-ASCII) --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Tue Feb 27 14:56:09 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/43c010f6e246b6131d393c7d
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Only log that we're waiting for channel type the first time.

    The other 500 times are implied.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wed Feb 28 08:52:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/7bfb1ef12e482ecfb30a9648
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Guard against answer() being called before the first channel is created.

    In this case, just accept whatever we get info on as the "first" one.

    Likely fixes #728
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wed Feb 28 11:00:41 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/dc04dba2dd1317000fcbc79e
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Early-out of the channel type loop for channel errors.

    If there's an error setting the channel or getting the channel
    type, give up on the session immediately.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sat Mar 2 15:48:30 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/bf25c42be169b69e9a0e2051
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    TRUE -> true
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sat Mar 2 15:48:30 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/84c90ed98b83651479a8ece0
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    client_on() still accepts a BOOL (not bool), so TRUE (not true) is correct
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sat Mar 2 15:48:30 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/ccce5a7c40c325f3e0628fe1
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Initialize sbbs_t::client and call client_on() as expected for logins

    See sbbs_t::logon() for example

    Note: the client.protocol is still "SSH" here (not "SFTP"). Perhaps that
    should be changed?

    Does any client actually support simultaneous "SSH" and "SFTP" sessions over the same socket?
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Sun Mar 3 10:36:45 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/479c00be08fcee60913272a4
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Fix issue when third SSH authentication attempt succeeds

    Because the session is activated on the *next* time through the
    loop, if the third attempt to authenticate (including public key)
    fails, it would leave the session inactive and fail to log in with
    a confusing error about an obsolete cryptlib.

    On success, decrement ssh_failed to ensure another pass through
    the loop.

    Also, add more debug logging around the auth so you can clearly
    see each failure, and log client_socket each time so it's clearly
    grouped.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Thu Oct 17 21:57:19 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/83fa4577d127ff775202a0a8
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Fix indentation of one line.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)