• DDMsgReader error when displayBoardInfoInHeader=true

    From Andre Robitaille@1:103/705 to GitLab issue in main/sbbs on Sun Feb 20 09:05:38 2022
    open https://gitlab.synchro.net/main/sbbs/-/issues/344

    When DDMsgReader.cfg has displayBoardInfoInHeader set to true, it throws an error when trying to list messages ('M' when reading a message):`!JavaScript DDMsgReader.js line 6877: TypeError: msgbase is undefined`Looks like the variable definitions are out of order. My line numbers are different than what I see in gitlab, so not sure if this actually starts at 6877 or 6987.```var msgGroupName = msg_area.grp_list[msgbase.cfg.grp_number].description;var subBoardName = "Unspecified";\var msgbase = new MsgBase(this.subBoardCode);```Moving msgbase above the others makes the error go away and the header start working. But not sure if it breaks anything else.This still breaks if trying to list messages 'L' from main, so not sure if that's related or should be a new issue. I'm unsure if curgrp and cursub aren't being passed to the module or if DDMsgReader isn't dealing with them properly.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Andre Robitaille@1:103/705 to GitLab note in main/sbbs on Sun Feb 20 19:29:39 2022
    https://gitlab.synchro.net/main/sbbs/-/issues/344#note_2297

    Seems that moving the line up, as I suggested in the issue text, actually breaks a scan across all sub-boards. After choosing "Go to the next message area - yes," it just ends up on a message list. So while my idea fixed the header, it broke the scan.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Andre@1:103/705 to All on Sun Feb 20 21:42:47 2022
    Re: DDMsgReader error when displayBoardInfoInHeader=true
    By: Andre Robitaille to GitLab note in main/sbbs on Sun Feb 20 2022 07:29 pm

    https://gitlab.synchro.net/main/sbbs/-/issues/344#note_2297

    Seems that moving the line up, as I suggested in the issue text, actually breaks a scan across all sub-boards. After choosing "Go to the next message area - yes," it just ends up on a message list. So while my idea fixed the header, it broke the scan.

    I ended up deleting this comment. Seems like this was introduced in the 1.44 update and isn't related to this issue.

    No idea what's going on with this scan/list behavior, so I'll have to dig through and see if it's something wonky with my config.


    - Andre

    ---
    þ Synchronet þ Radio Mentor BBS - bbs.radiomentor.org
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Andre Robitaille@1:103/705 to GitLab note in main/sbbs on Mon Feb 21 13:15:05 2022
    https://gitlab.synchro.net/main/sbbs/-/issues/344#note_2299

    Breaks email for me too. Main menu -> (E) -> (R)Same error, line 6988.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Mon Feb 21 13:56:25 2022
    https://gitlab.synchro.net/main/sbbs/-/issues/344#note_2300

    I'm able to reproduce and will look into it.Also if your line numbers are different than what appears in the Git repository, it's likely that you don't have the latest version.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab issue in main/sbbs on Thu Feb 24 21:18:14 2022
    close https://gitlab.synchro.net/main/sbbs/-/issues/344
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Andre Robitaille@1:103/705 to GitLab note in main/sbbs on Sat Feb 26 02:02:02 2022
    https://gitlab.synchro.net/main/sbbs/-/issues/344#note_2374

    Tested. Correctly fixed by a6f765b4.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)