Pop-Up Thingie

>>> Magnum BBS <<<
  • Home
  • Forum
  • Files
  • Log in

  1. Forum
  2. FidoNet
  3. SYNC SYSOPS
  • Merge branch 'dd_msg_reader_permission_check_optimizations' into 'mast

    From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tue Oct 10 23:08:19 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4319

    You don't need to open a message base to check its configuration. This will definitely slow down this function unnecessarily.

    Instead:
    ```
    canDelete = Boolean(msg_area.sub[this.subBoardCode].settings & SUB_DEL);
    ```

    I'm not clear why you're doing the ```canDelete = canDelete ||` either. Since you've already checked that `CanDelete` is false, that seems unnecessary. And the `== SUB_DEL` is also unnecessary.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tue Oct 10 23:09:33 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4320

    Ditto here. Not necessary to open the message base.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tue Oct 10 23:10:32 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4321

    Here too. And you've got the other unnecessary bits too.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tue Oct 10 23:10:51 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4322

    Same here. :-)
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Wed Oct 11 09:01:26 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4323

    Thanks. Also, I realized afterward I don't need the "canDelete ||".
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • Who's Online

  • Recent Visitors

    • Gwylbert
      Sun Aug 24 00:06:36 2025
      from Sydney, Nsw via Telnet
    • Bob Worm
      Sat Aug 23 21:17:17 2025
      from Wales, Uk via Telnet
    • Craig Colby
      Sat Aug 23 03:22:40 2025
      from Lewiston, Maine via Telnet
    • Bob Worm
      Fri Aug 22 22:17:23 2025
      from Wales, Uk via Telnet
    • Centurion
      Fri Aug 22 21:33:08 2025
      from Berea, Ohio via Telnet
    • Bob Worm
      Fri Aug 22 17:24:20 2025
      from Wales, Uk via Telnet
    • Bob Worm
      Fri Aug 22 08:41:05 2025
      from Wales, Uk via Telnet
    • Plume
      Fri Aug 22 07:29:56 2025
      from Uk via Telnet
  • System Info

    Sysop: Keyop
    Location: Huddersfield, West Yorkshire, UK
    Users: 537
    Nodes: 16 (2 / 14)
    Uptime: 154:05:23
    Calls: 10,251
    Calls today: 1
    Files: 13,981
    Messages: 6,408,337

© >>> Magnum BBS <<<, 2025