• Bug#1095392: smart-open FTBFS: tests hang

    From Rebecca N. Palmer@21:1/5 to All on Sat Mar 8 16:10:01 2025
    This also hangs in debci, and began doing so between 2025-01-29 and
    2025-02-01 (in unstable): https://ci.debian.net/packages/s/smart-open/unstable/amd64/

    Looking at what changed version between those, the obvious guess is python3-botocore 1.35 -> 1.36 (which did not trigger an autopkgtest
    because the *direct* dependency is python3-boto3).

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Sat Mar 8 20:50:01 2025
    Processing control commands:

    tag -1 pending
    Bug #1095392 [src:smart-open] smart-open: FTBFS: E: Build killed with signal TERM after 60 minutes of inactivity
    Added tag(s) pending.

    --
    1095392: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095392
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Rebecca N. Palmer@21:1/5 to All on Sat Mar 8 20:50:01 2025
    Control: tag -1 pending

    Hello,

    Bug #1095392 in smart-open reported by you has been fixed in the
    Git repository and is awaiting an upload. You can see the commit
    message below and you can check the diff of the fix at:

    https://salsa.debian.org/python-team/packages/smart-open/-/commit/6fa3605b5e817b19fb915f543584d632465f7b53

    ------------------------------------------------------------------------
    Tests: disable checksums, as the expected results are from older
    botocore versions. (Closes: #1095392) ------------------------------------------------------------------------

    (this message was generated automatically)
    --
    Greetings

    https://bugs.debian.org/1095392

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Rebecca N. Palmer@21:1/5 to All on Sun Mar 9 00:40:01 2025
    Control: tags -1 patch

    In addition to the hangs, several tests fail.

    It looks like the trigger is botocore enabling checksums by default: https://sources.debian.org/src/python-boto3/1.36.0%2Bdfsg-1/CHANGELOG.rst/#L12

    Turning them off with AWS_REQUEST_CHECKSUM_CALCULATION=when_required
    makes the tests pass: https://salsa.debian.org/python-team/packages/smart-open/-/tree/experiments1095392?ref_type=heads

    However, I haven't looked closely enough to say whether this is actually
    a full solution.

    It isn't obviously known to upstream.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Sun Mar 9 00:40:01 2025
    Processing control commands:

    tags -1 patch
    Bug #1095392 [src:smart-open] smart-open: FTBFS: E: Build killed with signal TERM after 60 minutes of inactivity
    Added tag(s) patch.

    --
    1095392: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095392
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Sun Mar 9 12:50:01 2025
    Processing control commands:

    tags -1 - patch
    Bug #1095392 [src:smart-open] smart-open: FTBFS: E: Build killed with signal TERM after 60 minutes of inactivity
    Removed tag(s) patch.
    tags -1 - pending
    Bug #1095392 [src:smart-open] smart-open: FTBFS: E: Build killed with signal TERM after 60 minutes of inactivity
    Removed tag(s) pending.
    retitle -1 smart-open: tests fail, S3 possibly broken
    Bug #1095392 [src:smart-open] smart-open: FTBFS: E: Build killed with signal TERM after 60 minutes of inactivity
    Changed Bug title to 'smart-open: tests fail, S3 possibly broken' from 'smart-open: FTBFS: E: Build killed with signal TERM after 60 minutes of inactivity'.

    --
    1095392: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095392
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Rebecca N. Palmer@21:1/5 to All on Sun Mar 9 12:50:01 2025
    Control: tags -1 - patch
    Control: tags -1 - pending
    Control: retitle -1 smart-open: tests fail, S3 possibly broken

    That no longer looks like a real solution, as it's not just tests
    looking at the underlying binary representation that fail: there are
    also tests (e.g. test_readline, test_s3_iter_lines,
    test_s3_read/seek_moto) that simply write then read an S3 object in the
    same file mode and don't get back what they put in.

    (Turning off checksum generation by default during actual use probably
    wouldn't work either, given that this presumably needs to be able to
    read S3 objects created by other libraries.)

    However, if it's as completely broken on S3 with recent botocore as the
    above implies, then it's odd that neither smart_open upstream nor
    snakemake upstream seem to have noticed. (snakemake upstream does still
    use smart_open.) *Possibly* we have a bad combination of boto* and moto versions?

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Sun Mar 9 19:50:02 2025
    Processing control commands:

    reassign -1 python3-moto
    Bug #1095392 [src:smart-open] smart-open: tests fail, S3 possibly broken
    Bug reassigned from package 'src:smart-open' to 'python3-moto'.
    No longer marked as found in versions smart-open/7.1.0-1.
    Ignoring request to alter fixed versions of bug #1095392 to the same values previously set
    found -1 5.0.11-3
    Bug #1095392 [python3-moto] smart-open: tests fail, S3 possibly broken
    Marked as found in versions python-moto/5.0.11-3.
    tags -1 fixed-upstream
    Bug #1095392 [python3-moto] smart-open: tests fail, S3 possibly broken
    Added tag(s) fixed-upstream.
    retitle -1 smart-open FTBFS: tests hang/fail - moto too old
    Bug #1095392 [python3-moto] smart-open: tests fail, S3 possibly broken
    Changed Bug title to 'smart-open FTBFS: tests hang/fail - moto too old' from 'smart-open: tests fail, S3 possibly broken'.

    --
    1095392: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095392
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Rebecca N. Palmer@21:1/5 to All on Sun Mar 9 19:50:02 2025
    Control: reassign -1 python3-moto
    Control: found -1 5.0.11-3
    Control: tags -1 fixed-upstream
    Control: retitle -1 smart-open FTBFS: tests hang/fail - moto too old

    *Possibly* we have a bad combination of boto* and moto
    versions?

    Looks like we do - when botocore/boto3/moto are installed via pip, botocore==1.36.22 boto3==1.36.0 moto==5.0.11 (the same versions as
    Debian) fails: https://salsa.debian.org/python-team/packages/smart-open/-/jobs/7224045/raw while botocore==1.36.22 boto3==1.36.0 moto==5.1.1 succeeds: https://salsa.debian.org/python-team/packages/smart-open/-/jobs/7224173/raw (Please do not actually upload these packages, as autopkgtests that
    download and run executables are prohibited in Debian.)

    This suggests that updating Debian's python3-moto to 5.1.1 will fix this
    bug.

    (moto's own tests aren't failing, but it only runs a small fraction of
    them.)

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Sun Mar 9 23:10:01 2025
    Processing control commands:

    tags -1 patch
    Bug #1095392 [python3-moto] smart-open FTBFS: tests hang/fail - moto too old Added tag(s) patch.

    --
    1095392: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095392
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Mon Mar 10 14:10:02 2025
    This is a multi-part message in MIME format...

    Your message dated Mon, 10 Mar 2025 13:06:44 +0000
    with message-id <E1trcqC-00HAFs-Gz@fasolo.debian.org>
    and subject line Bug#1095392: fixed in python-moto 5.1.1-1
    has caused the Debian Bug report #1095392,
    regarding smart-open FTBFS: tests hang/fail - moto too old
    to be marked as done.

    This means that you claim that the problem has been dealt with.
    If this is not the case it is now your responsibility to reopen the
    Bug report if necessary, and/or fix the problem forthwith.

    (NB: If you are a system administrator and have no idea what this
    message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
    immediately.)


    --
    1095392: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095392
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    Received: (at submit) by bugs.debian.org; 7 Feb 2025 12:13:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
    (2021-04-09) on buxtehude.debian.org
    X-Spam-Level:
    X-Spam-Status: No, score=-121.1 required=4.0 tests=ALL_TRUSTED,BAYES_00,
    BODY_INCLUDES_PACKAGE,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,
    DKIM_VALID_AU,DKIM_VALID_EF,FOURLA,FROMDEVELOPER,HAS_PACKAGE,
    SPF_HELO_PASS,SPF_NONE,USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST,
    X_DEBBUGS_CC autolearn=ham autolearn_force=no
    version=3.4.6-bugs.debian.org_2005_01_02
    X-Spam-Bayes: score:0.0000 Tokens: new, 15; hammy, 150; neutral, 238; spammy,
    0. spammytokens: hammytokens:0.000-+--python3, 0.000-+--pkgbuilddir,
    0.000-+--PKGBUILDDIR, 0.000-+--trixie, 0.000-+--sk:dh_auto
    Return-path: <sanvila@debian.org>
    Received: from mailly.debian.org ([2001:41b8:202:deb:6564:a62:52c3:4b7