• Bug#1100044: grpc FTBFS with abseil 20240722.0

    From Stefano Rivera@21:1/5 to All on Mon Mar 10 17:50:01 2025
    Source: grpc
    Version: 1.51.1-5
    Severity: serious
    Tags: ftbfs patch

    The abseil 20240722.0 transition has started (#1081553) and grpc FTBFS
    with the new version:

    /usr/bin/c++ -I/build/reproducible-path/grpc-1.51.1/include -I/build/reproducible-path/grpc-1.51.1 -I/build/reproducible-path/grpc-1.51.1/third_party/address_sorting/include -I/build/reproducible-path/grpc-1.51.1/src/core/ext/upb-generated -I/build/
    reproducible-path/grpc-1.51.1/src/core/ext/upbdefs-generated -I/build/reproducible-path/grpc-1.51.1/third_party/upb -I/build/reproducible-path/grpc-1.51.1/third_party/xxhash -g -O2 -ffile-prefix-map=/build/reproducible-path/grpc-1.51.1=. -fstack-
    protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++14 -fPIC -pthread -DNOMINMAX -MD -MT CMakeFiles/grpc.dir/src/core/lib/iomgr/wakeup_fd_pipe.cc.o -MF CMakeFiles/grpc.dir/
    src/core/lib/iomgr/wakeup_fd_pipe.cc.o.d -o CMakeFiles/grpc.dir/src/core/lib/iomgr/wakeup_fd_pipe.cc.o -c /build/reproducible-path/grpc-1.51.1/src/core/lib/iomgr/wakeup_fd_pipe.cc
    /build/reproducible-path/grpc-1.51.1/src/core/lib/iomgr/tcp_posix.cc: In function ‘void update_rcvlowat({anonymous}::grpc_tcp*)’:
    /build/reproducible-path/grpc-1.51.1/src/core/lib/iomgr/tcp_posix.cc:861:19: error: ‘StrCat’ is not a member of ‘absl’
    861 | absl::StrCat("Cannot set SO_RCVLOWAT on fd=", tcp->fd,
    | ^~~~~~ /build/reproducible-path/grpc-1.51.1/src/core/lib/iomgr/tcp_posix.cc: In function ‘bool tcp_do_read({anonymous}::grpc_tcp*, grpc_error_handle*)’:
    /build/reproducible-path/grpc-1.51.1/src/core/lib/iomgr/tcp_posix.cc:951:58: error: ‘StrCat’ is not a member of ‘absl’
    951 | tcp_annotate_error(absl::InternalError(absl::StrCat(
    | ^~~~~~

    This looks like some missing #includes. I'll pick my way through and
    find them.

    In the meantime, I see that 1.59.5-1 already supports the newer abseil,
    here's a patch to get 1.59.5-1 building gain (essentially, merging the
    latest commit from my MR to unstable).

    diff --git a/debian/changelog b/debian/changelog
    index 993c66177d..48f17b9a92 100644
    --- a/debian/changelog
    +++ b/debian/changelog
    @@ -1,3 +1,12 @@
    +grpc (1.59.5-1.1) unstable; urgency=medium
    +
    + [ Stefano Rivera <stefanor@debian.org> ]
    + * Patch: Cython 3 support.
    + * Patch: Python 3.13 support (closes: #1084603).
    + * Patch: GCC-14 support (closes: #1075045).
    +
    + -- Stefano Rivera <stefanor@debian.org> Mon, 10 Mar 2025 09:06:20 -0400
    +
    grpc (1.59.5-1) experimental; urgency=medium

    * New major upstream release.
    diff --git a/debian/control b/debian/control
    index 38aff01ec8..4cf6990138 100644
    --- a/debian/control
    +++ b/debian/control
    @@ -12,7 +12,7 @@ Build-Depends: dpkg-dev (>= 1.22.5), debhelper-compat (= 13), cmake, pkgconf,
    ruby-rspec, ruby-simplecov,
    dh-python,
    python3-all-dev,
    - cython3-legacy,
    + cython3,
    python3-six,
    python3-setuptools,
    python3-pkg-resources,
    diff --git a/debian/patches/cython3-deadlocks.patch b/debian/patches/cython3-deadlocks.patch
    new file mode 100644
    index 0000000000..fd0362de99
    --- /dev/null
    +++ b/debian/patches/c
  • From Debian Bug Tracking System@21:1/5 to All on Mon Mar 10 20:30:01 2025
    Processing control commands:

    tags 1100044 + pending
    Bug #1100044 [src:grpc] grpc FTBFS with abseil 20240722.0
    Added tag(s) pending.

    --
    1100044: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1100044
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Stefano Rivera@21:1/5 to All on Mon Mar 10 20:30:01 2025
    Control: tags 1100044 + pending

    Dear maintainer,

    I've prepared an NMU for grpc (versioned as 1.51.1-5.1) and
    uploaded it to DELAYED/5. Please feel free to tell me if I
    should delay it longer.

    Or, of course you could take the approach from my previous patch, and
    upgrade to a newer upstream release.

    Regards.

    Stefano

    diff -Nru grpc-1.51.1/debian/changelog grpc-1.51.1/debian/changelog
    --- grpc-1.51.1/debian/changelog 2024-11-11 13:25:37.000000000 -0400
    +++ grpc-1.51.1/debian/changelog 2025-03-10 15:12:33.000000000 -0400
    @@ -1,3 +1,10 @@
    +grpc (1.51.1-5.1) unstable; urgency=medium
    +
    + * Non-maintainer upload.
    + * Patch: Support abseil 20240722.0. (closes: #1100044)
    +
    + -- Stefano Rivera <stefanor@debian.org> Mon, 10 Mar 2025 15:12:33 -0400
    +
    grpc (1.51.1-5) unstable; urgency=medium

    [ Stefano Rivera <stefanor@debian.org> ]
    diff -Nru grpc-1.51.1/debian/patches/abseil-20240722.0.patch grpc-1.51.1/debian/patches/abseil-20240722.0.patch
    --- grpc-1.51.1/debian/patches/abseil-20240722.0.patch 1969-12-31 20:00:00.000000000 -0400
    +++ grpc-1.51.1/debian/patches/abseil-20240722.0.patch 2025-03-10 15:12:33.000000000 -0400
    @@ -0,0 +1,30 @@
    +From: DanilChapovalov <danilchap@webrtc.org>
    +Date: Fri, 29 Sep 2023 18:43:57 +0200
    +Subject: [Build] Add missing absl includes (#34499)
    +
    +To avoid depending on transitive includes, specially avoid relying on +transitive include status.
  • From Debian Bug Tracking System@21:1/5 to All on Mon Mar 10 23:40:01 2025
    This is a multi-part message in MIME format...

    Your message dated Mon, 10 Mar 2025 22:35:34 +0000
    with message-id <E1trlig-001hIy-OP@fasolo.debian.org>
    and subject line Bug#1100044: fixed in grpc 1.51.1-6
    has caused the Debian Bug report #1100044,
    regarding grpc FTBFS with abseil 20240722.0
    to be marked as done.

    This means that you claim that the problem has been dealt with.
    If this is not the case it is now your responsibility to reopen the
    Bug report if necessary, and/or fix the problem forthwith.

    (NB: If you are a system administrator and have no idea what this
    message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
    immediately.)


    --
    1100044: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1100044
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    Received: (at submit) by bugs.debian.org; 10 Mar 2025 16:38:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
    (2021-04-09) on buxtehude.debian.org
    X-Spam-Level:
    X-Spam-Status: No, score=-106.1 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
    DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FOURLA,
    FROMDEVELOPER,GMAIL,MD5_SHA1_SUM,SPF_HELO_NONE,SPF_NONE,
    USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST autolearn=ham
    autolearn_force=no version=3.4.6-bugs.debian.org_2005_01_02 X-Spam-Bayes: score:0.0000 Tokens: new, 72; hammy, 150; neutral, 1198; spammy,
    0. spammytokens: hammytokens:0.000-+--cmake, 0.000-+--wdatetime,
    0.000-+--Wdatetime, 0.000-+--Wdate-time, 0.000-+--wdate-time Return-path: <stefanor@debian.org>
    Received: from smtp.tumbleweed.org.za ([2001:470:c91e::2]:43142)
    by buxtehude.debian.org with esmtps (TLS1.3:E