• Bug#1100050: osmocom-dahdi-dkms: install fails because of uninterpreted

    From Agathe Porte@21:1/5 to All on Mon Mar 10 19:00:01 2025
    Package: osmocom-dahdi-dkms
    Version: 0.0~git20241003.b2ea348-3
    Severity: grave
    Justification: renders package unusable
    X-Debbugs-Cc: gagath@debian.org

    Dear Maintainer,

    When trying to install the osmocom-dahdi-dkms package on unstable, the
    build of the modules fail. This is because the dkms.conf file in not
    located in the correct location. The #MODULE_VERSION# string not being interpreted by dh_dkms:

    $ dpkg -L osmocom-dahdi-dkms
    /.
    /usr
    /usr/share
    /usr/share/doc
    /usr/share/doc/osmocom-dahdi-dkms
    /usr/share/doc/osmocom-dahdi-dkms/LICENSE.firmware
    /usr/share/doc/osmocom-dahdi-dkms/README
    /usr/share/doc/osmocom-dahdi-dkms/changelog.Debian.gz
    /usr/share/doc/osmocom-dahdi-dkms/copyright
    /usr/src
    /usr/src/osmocom-dahdi-#MODULE_VERSION#
    /usr/src/osmocom-dahdi-#MODULE_VERSION#/dkms.conf
    /usr/src/osmocom-dahdi-0.0~git20241003.b2ea348
    /usr/src/osmocom-dahdi-0.0~git20241003.b2ea348/Makefile
    ...

    This regression seems to be coming from this commit in the salsa
    repository of the source package:

    commit 2b4c1196b441237bb30a469494379076d2980ee5
    Author: Andreas Beckmann <anbe@debian.org>
    Date: Sat Feb 8 00:02:10 2025 +0100

    simplify debian/rules

    ...

    diff --git a/debian/rules b/debian/rules
    index 3382d61..b46c561 100755
    --- a/debian/rules
    +++ b/debian/rules
    @@ -5,28 +5,11 @@

    include /usr/share/dpkg/pkg-info.mk

    -export DEB_BUILD_MAINT_OPTIONS = hardening=+all
    -
    %:
    - dh $@ --with autoreconf
    -
    -# Don't want to build. Just send source code to
    -# package to be built by DKMS
    -override_dh_auto_build:
    + dh $@ --buildsystem none

    ...

    Switching to the "none" buildsystem seems to prevent dh_dkms from being
    run, even if it Build-Depends on dh-sequence-dkms.

    One simple solution to this problem that I have experimented locally is
    to pass the "--with dkms" option to dh in the debian/rules file:

    diff --git c/debian/rules i/debian/rules
    index b46c561..991f6f0 100755
    --- c/debian/rules
    +++ i/debian/rules
    @@ -6,7 +6,7 @@
    include /usr/share/dpkg/pkg-info.mk

    %:
    - dh $@ --buildsystem none
    + dh $@ --buildsystem none --with dkms

    Since "dh-sequence-dkms" is broken for this usecase, maybe the
    Build-Depends should also be switched from "dh-sequence-dkms" to
    "dh-dkms" if it is accepted.

    After applying this patch the dkms.conf file is correctly located with
    the source files in ./usr/src/osmocom-dahdi-0.0~git20241003.b2ea348/,
    showing that dh_dkms was able to substitute the value correctly.

    I will attach a patch to this bug, as well as create a merge request on
    the salsa repository, as soon as I get back the bug number from the BTS.

    Thanks.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Agathe Porte@21:1/5 to All on Mon Mar 10 19:40:01 2025
    Control: tag -1 +patch

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Mon Mar 10 19:40:01 2025
    Processing control commands:

    tag -1 +patch
    Bug #1100050 [osmocom-dahdi-dkms] osmocom-dahdi-dkms: install fails because of uninterpreted #MODULE_VERSION# in dkms.conf
    Added tag(s) patch.

    --
    1100050: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1100050
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Tue Mar 11 00:10:04 2025
    This is a multi-part message in MIME format...

    Your message dated Mon, 10 Mar 2025 23:06:21 +0000
    with message-id <E1trmCT-001mQL-Vv@fasolo.debian.org>
    and subject line Bug#1100050: fixed in osmocom-dahdi-linux 0.0~git20241003.b2ea348-4
    has caused the Debian Bug report #1100050,
    regarding osmocom-dahdi-dkms: install fails because of uninterpreted #MODULE_VERSION# in dkms.conf
    to be marked as done.

    This means that you claim that the problem has been dealt with.
    If this is not the case it is now your responsibility to reopen the
    Bug report if necessary, and/or fix the problem forthwith.

    (NB: If you are a system administrator and have no idea what this
    message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
    immediately.)


    --
    1100050: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1100050
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    Received: (at submit) by bugs.debian.org; 10 Mar 2025 17:47:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
    (2021-04-09) on buxtehude.debian.org
    X-Spam-Level:
    X-Spam-Status: No, score=-21.1 required=4.0 tests=BAYES_00,
    BODY_INCLUDES_PACKAGE,FOURLA,FROMDEVELOPER,HAS_PACKAGE,MD5_SHA1_SUM,
    RDNS_NONE,SPF_NONE,XMAILER_REPORTBUG autolearn=ham autolearn_force=no
    version=3.4.6-bugs.debian.org_2005_01_02
    X-Spam-Bayes: score:0.0000 Tokens: new, 39; hammy, 150; neutral, 92; spammy,
    0. spammytokens: hammytokens:0.000-+--XDebbugsCc,
    0.000-+--X-Debbugs-Cc, 0.000-+--buildsystem, 0.000-+--H*M:reportbug,
    0.000-+--H*MI:reportbug
    Return-path: <gagath@debian.org>
    Received: from [2a01:e0a:d3:11e0:1102:a740:11bf:3537] (port=38318 helo=[127.0.1.1])
    by buxtehude.debian.org with esmtp (Exim 4.94.2)
    (envelope-from <gagath@debian.org>)