• Bug#1086472: marco FTBFS on 32-bit with 64-bit time_t with gcc 14

    From Simon McVittie@21:1/5 to Bastian Germann on Wed Mar 12 12:10:01 2025
    On Tue, 11 Mar 2025 at 20:13:10 +0100, Bastian Germann wrote:
    Control: clone -1 -2
    Control: reassign -2 libstartup-notification0-dev

    Please change sn_startup_sequence_get_last_active_time (and for
    consistency, sn_startup_sequence_get_initiated_time as well) argument *tv_sec >to have a time_t type so it can be used properly on 32 bit systems with >time_t being 64 bit wide, which is the configuration for armel and armhf >release architectures.

    I don't think changing the API and ABI of libstartup-notification to
    match marco's assumptions, as proposed in the cloned bug #1100147, is a
    good solution to this FTBFS. Please see #1100147 for full reasoning on
    this (among other things, as far as I can see, that change would cause
    FTBFS in at least 3 other packages).

    Instead, I think the answer to this should be to apply a patch to
    src:marco to make its behaviour match the documented API and ABI of libstartup-notification, perhaps similar to the way xfwm4 does it:

    /* https://sources.debian.org/src/xfwm4/4.20.0-1/src/startup_notification.c/?hl=139#L125 */
    time_t tv_sec;
    suseconds_t tv_usec;
    long l_sec, l_usec;
    /* ... */
    sn_startup_sequence_get_last_active_time (sequence, &l_sec, &l_usec);
    tv_sec = l_sec; tv_usec = l_usec;
    /* continue to do things with tv_sec and tv_usec */

    smcv

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)