On Sun, Mar 30, 2025 at 12:27:38AM +0000, Santiago Vila wrote:

During a rebuild of all packages in unstable, your package failed to build:

[ Note 1: I recommend that you add a debian/salsa-ci.yml file to check for buildability ]

[ Note 2: The salsa project does not match the source package name, this is probably
an anomaly that you might want to fix ]

--------------------------------------------------------------------------------
[...]
adding 'ytmusicapi-0.0.0.dist-info/top_level.txt'
adding 'ytmusicapi-0.0.0.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Successfully built ytmusicapi-0.0.0-py3-none-any.whl
I: pybuild plugin_pyproject:144: Unpacking wheel built for python3.13 with "installer" module
dh_auto_test -O--buildsystem=pybuild
I: pybuild base:311: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.13/build; python3.13 -m unittest discover -v
tests.auth.test_oauth (unittest.loader._FailedTest.tests.auth.test_oauth) ... ERROR
tests.mixins.test_browsing (unittest.loader._FailedTest.tests.mixins.test_browsing) ... ERROR
tests.mixins.test_library (unittest.loader._FailedTest.tests.mixins.test_library) ... ERROR
tests.mixins.test_playlists (unittest.loader._FailedTest.tests.mixins.test_playlists) ... ERROR
tests.mixins.test_search (unittest.loader._FailedTest.tests.mixins.test_search) ... ERROR
tests.mixins.test_uploads (unittest.loader._FailedTest.tests.mixins.test_uploads) ... ERROR
tests.mixins.test_watch (unittest.loader._FailedTest.tests.mixins.test_watch) ... ERROR
tests.test_ytmusic (unittest.loader._FailedTest.tests.test_ytmusic) ... ERROR

======================================================================
ERROR: tests.auth.test_oauth (unittest.loader._FailedTest.tests.auth.test_oauth)
---------------------------------------------------------------------- >ImportError: Failed to import test module: tests.auth.test_oauth
Traceback (most recent call last):
File "/usr/lib/python3.13/unittest/loader.py", line 396, in _find_test_path
module = self._get_module_from_name(name)
File "/usr/lib/python3.13/unittest/loader.py", line 339, in _get_module_from_name
__import__(name)
~~~~~~~~~~^^^^^^
File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.13/build/tests/auth/test_oauth.py", line 8, in <module>
import pytest
ModuleNotFoundError: No module named 'pytest'

As well as the obvious missing build-dependencies, the tests seem to
require a test.cfg with YouTube account credentials (judging by .github/workflows/coverage.yml, anyway).

Salvo, should we just disable the tests? It's not clear to me that
there are many other options here.

Thanks,

--
Colin Watson (he/him) [cjwatson@debian.org]

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

As well as the obvious missing build-dependencies, the tests seem to
require a test.cfg with YouTube account credentials (judging by .github/workflows/coverage.yml, anyway).

Salvo, should we just disable the tests? It's not clear to me that
there are many other options here.

Hello,

the tests were not running in my chroot when I originally made the package, so I'm not sure why they got ran later on.

As I had seen not depending on pytest would just skip them.

Anyway I was kinda sitting on this one on purpose because since there's no way for audiotube to make it for trixie, there's also no reason for this to be in trixie either, so I didn't really give this a priority.

I can look into it if you'd want it to be in trixie, but I'm 100% fine if it will remain left out.

--
Salvo Tomaselli

"Io non mi sento obbligato a credere che lo stesso Dio che ci ha dotato di senso, ragione ed intelletto intendesse che noi ne facessimo a meno."
-- Galileo Galilei

https://ltworf.codeberg.page/

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mon, Apr 07, 2025 at 07:58:32PM +0200, Salvo Tomaselli wrote:

the tests were not running in my chroot when I originally made the package, so >I'm not sure why they got ran later on.

As I had seen not depending on pytest would just skip them.

I'm not sure why they wouldn't have run before, in the absence of a
forked dh-python or something. pybuild currently falls back to
"{interpreter} -m unittest discover -v".

Anyway I was kinda sitting on this one on purpose because since there's no way >for audiotube to make it for trixie, there's also no reason for this to be in >trixie either, so I didn't really give this a priority.

I can look into it if you'd want it to be in trixie, but I'm 100% fine if it >will remain left out.

No great rush specifically for trixie; I just try to stay on top of the
Python team's bug list.

--
Colin Watson (he/him) [cjwatson@debian.org]

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)