• Bug#1104178: elpa-doom-themes: upgrade fails: cannot overwrite non-dire

    From Sean Whitton@21:1/5 to Xiyue Deng on Mon Apr 28 04:40:02 2025
    Hello,

    On Sun 27 Apr 2025 at 03:25am -07, Xiyue Deng wrote:

    Interestingly, I cannot reproduce this with "apt dist-upgrade" which is
    why I didn't notice this issue earlier. On inspecting the install log,
    it looks like with "dist-upgrade", it will upgrade the emacs
    installation before addons which will first uninstall all addons and re-install them after emacs is configured, and hence worked around this potential issue.

    Still, I think it's better to have this fixed so that it works in all
    cases. I have tested a fix in the "bug#1104178" branch to be working.
    The diff can be seen here[1]. Please review.

    It's an RC bug regardless; we always support partial upgrades, and
    therefore can't rely on package upgrade order like that.

    Given the freeze and dh-elpa's status as a toolchain package, we need to
    handle this very carefully.

    I think we need David's review on the basic approach taken by the patch
    before proceeding much further, but I can comment on the shell
    scripting:

    - TIL unlink(1). Let's just use rm(1).

    - Quote the output of readlink, i.e. "$(readlink "${SYMLINK}")".
    Quotation resets inside $().

    - "for file in ./*" not "for file in *"
    per https://dwheeler.com/essays/filenames-in-shell.html sec. 1.2

    --
    Sean Whitton

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQJNBAEBCgA3FiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAmgO6T8ZHHNwd2hpdHRv bkBzcHdoaXR0b24ubmFtZQAKCRBpW3rkvwZiQHxYD/9hLBSLnr/PYjpFvJvBxLHC 7GJpHSGLwxzXFM6td/RuVPsI+gFG5ki23l23VyLVWXFyS0fci0TZv1rI1r8CpcyM GRfKsVbk2oduWsJRaIt408E4xIqpouhd7j+saW6Yx1TcuIbZ6v85WfIjvwT68id4 /AitgdJqTsItP647fbV1loRRpKWpzTdnrUVAjckZIHrR3W6tvY9tSpGcD5AeQwbW FWoaAfNgWtEnX4GIZ0IBsYYU67HowWYBEeJMbGvqLkz/VLdvT579MtJaP3mkgPsR bmKlmJ+tntgg11iZgTnaySXzUPART7a3ZAalhgXhtZHB7Z7BRbq+84Qvj/eFYFW7 3vfiXNA3vvt4WY6t9zKBjPsPx07lRI/axxCM0rRv2ZxHv4eMonm2xuoqD/7WHu2/ gh9bOADWV6p09VQ/uJCD8Dm1AEjnf9MTkmSpYC2UyGl3j6UCdfalCHeESgGlVbIY 0gCzHDfrx76Zl9NXSxKeofM17OI3Luf8uoG06Q5jkK5JNjYtssS85fv856xKmwHK DjAN+TslSF0T4DvBvDMqd0NDDcS6DOKvEcLOCZstxh6NZ39fTykbrRPeD98h3uC7 WV5K+iMeIQmbwevyxVh/ZkUbLFVkDa/KL7MrPGKEBogSPfgPwV/fvxBDrSOBXmZ8 /HahlaoT9eTjLrb39AxpsA==7U4Y
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Us
  • From Sean Whitton@21:1/5 to Xiyue Deng on Wed May 7 07:30:01 2025
    Hello,

    On Mon 05 May 2025 at 01:26pm -07, Xiyue Deng wrote:

    For build phase, dh-elpa is mostly used for detecting and running tests
    (ERT or Buttercup), not the actual building (which is skipped most of
    the time).

    I think you meant dh_elpa_test here and I don't think it's relevant to
    this bug at all?

    --
    Sean Whitton

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQJNBAEBCgA3FiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAmga7V8ZHHNwd2hpdHRv bkBzcHdoaXR0b24ubmFtZQAKCRBpW3rkvwZiQNiNEACYEJOsR1gzZVje5jiqIISY t+mvktP2GnW58spNqKLzYMK/6bxCrxjWF3jzO1ji6jpAyGY0DlmfDVWXYTOfDd+f b1rBeZPmPZnX0Dthf/Dwt9rNhatXtMeTD9U56ZLLLjrM3USS1UNSJb3usX9JF1Tu 7tC8f5d+2z0g2ZUuGgjChN6xxLotXr3EMdiVyUBF64LKgJtbi+B9dNK+8vOcvvll 9h944zFU9hXq10vn0O8z4ycpwhWCOJqlhLoH5Z530bPY+5HwZYqenpUvYB0yE75R DJCYnehyFWCCrRGrBOtR8cy+nWWTznG1HXUoHxvZDFZja7LQ0e6ShAvfofTx5Tu7 J6RKepEoHgWalyuASrv70WMgykUeTCYf8vBpsDhd9xAReosWwkaXJYjJD6qAN2E0 usOPIeLhHaaGxbJFieawtFdhbaKQkQzoJirGlY7qRdFrVPgM8nOWLwVoKLvfe8rm 03rMVsUyNhpGh7Jbm5yIlo6otz8gHJOf0FYXaL27RBGvJwCGMJmPcG+62mk08oOl HXrldw/3gh3yuA71d0uA1UfwzBLuyNFpiSlkSoAW0ct9K+rKvV6n+dYUIabBWC+E PON3+/aWRTKmvdzzW5CCMznvcQzLFkApfJx1ZauCVf2ctV6QIzS1hqJkdWVR3z+I uOntd7xeHDv9W3jNZwiTSQ==7ook
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Us