Hello,
On Sun 27 Apr 2025 at 03:25am -07, Xiyue Deng wrote:
Interestingly, I cannot reproduce this with "apt dist-upgrade" which is
why I didn't notice this issue earlier. On inspecting the install log,
it looks like with "dist-upgrade", it will upgrade the emacs
installation before addons which will first uninstall all addons and re-install them after emacs is configured, and hence worked around this potential issue.
Still, I think it's better to have this fixed so that it works in all
cases. I have tested a fix in the "bug#1104178" branch to be working.
The diff can be seen here[1]. Please review.
It's an RC bug regardless; we always support partial upgrades, and
therefore can't rely on package upgrade order like that.
Given the freeze and dh-elpa's status as a toolchain package, we need to
handle this very carefully.
I think we need David's review on the basic approach taken by the patch
before proceeding much further, but I can comment on the shell
scripting:
- TIL unlink(1). Let's just use rm(1).
- Quote the output of readlink, i.e. "$(readlink "${SYMLINK}")".
Quotation resets inside $().
- "for file in ./*" not "for file in *"
per
https://dwheeler.com/essays/filenames-in-shell.html sec. 1.2
--
Sean Whitton
--=-=-Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJNBAEBCgA3FiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAmgO6T8ZHHNwd2hpdHRv bkBzcHdoaXR0b24ubmFtZQAKCRBpW3rkvwZiQHxYD/9hLBSLnr/PYjpFvJvBxLHC 7GJpHSGLwxzXFM6td/RuVPsI+gFG5ki23l23VyLVWXFyS0fci0TZv1rI1r8CpcyM GRfKsVbk2oduWsJRaIt408E4xIqpouhd7j+saW6Yx1TcuIbZ6v85WfIjvwT68id4 /AitgdJqTsItP647fbV1loRRpKWpzTdnrUVAjckZIHrR3W6tvY9tSpGcD5AeQwbW FWoaAfNgWtEnX4GIZ0IBsYYU67HowWYBEeJMbGvqLkz/VLdvT579MtJaP3mkgPsR bmKlmJ+tntgg11iZgTnaySXzUPART7a3ZAalhgXhtZHB7Z7BRbq+84Qvj/eFYFW7 3vfiXNA3vvt4WY6t9zKBjPsPx07lRI/axxCM0rRv2ZxHv4eMonm2xuoqD/7WHu2/ gh9bOADWV6p09VQ/uJCD8Dm1AEjnf9MTkmSpYC2UyGl3j6UCdfalCHeESgGlVbIY 0gCzHDfrx76Zl9NXSxKeofM17OI3Luf8uoG06Q5jkK5JNjYtssS85fv856xKmwHK DjAN+TslSF0T4DvBvDMqd0NDDcS6DOKvEcLOCZstxh6NZ39fTykbrRPeD98h3uC7 WV5K+iMeIQmbwevyxVh/ZkUbLFVkDa/KL7MrPGKEBogSPfgPwV/fvxBDrSOBXmZ8 /HahlaoT9eTjLrb39AxpsA==7U4Y
-----END PGP SIGNATURE-----
--- SoupGate-Win32 v1.05
* Origin: fsxNet Us