• Bug#1104514: screen: about the typo in configure.ac

    From Vincent Lefevre@21:1/5 to Vincent Lefevre on Mon May 5 13:10:01 2025
    On 2025-05-05 03:10:50 +0200, Vincent Lefevre wrote:
    Removing utempter support in debian/rules by either removing
    the --enable-utempter option or changing it to --disable-utempter
    has no effect, but if I understand correctly the configure.ac file,
    this option is not used! Well, this seems to be due to a typo:

    AC_ARG_ENABLE(utempter, [ --enable-utempter enable utempter support]) if test "$enable_pam" = "yes"; then
    AC_CHECKING(ut_host)
    AC_TRY_COMPILE([
    #include <time.h>
    #include <sys/types.h>
    #if defined(SVR4) && !defined(DGUX)
    #include <utmpx.h>
    #define utmp utmpx
    #else
    #include <utmp.h>
    #endif
    ],[struct utmp u; u.ut_host[0] = 0;], AC_DEFINE(UTHOST)) AC_CHECK_HEADER(utempter.h, have_utempter=yes, have_utempter=no)
    if test "$have_utempter" = yes; then
    AC_DEFINE(HAVE_UTEMPTER)
    LIBS="$LIBS -lutempter"
    fi
    fi

    Instead of

    if test "$enable_pam" = "yes"; then

    it should be

    if test "$enable_utempter" = "yes"; then

    The buggy code comes from debian/patches/63-add-utempter-switch.patch
    as a fix of

    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819781

    for sh4 at least. So fixing the typo could break on some architectures.

    But anyway, the above code will disappear if utmp support is removed everywhere.

    --
    Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
    100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
    Work: CR INRIA - computer arithmetic / Pascaline project (LIP, ENS-Lyon)

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)