• Bug#1106429: node-finalhandler: FTBFS: test "should encode bad pathname

    From Santiago Vila@21:1/5 to All on Sat May 24 18:50:03 2025
    Package: src:node-finalhandler
    Version: 1.2.0+~1.1.1-2
    Severity: serious
    Tags: ftbfs trixie sid

    Dear maintainer:

    During a rebuild of all packages in unstable, your package failed to build:

    --------------------------------------------------------------------------------
    [...]
    debian/rules clean
    dh clean
    dh_auto_clean --buildsystem=nodejs
    rm -rf ./node_modules/.cache ./.nyc_output
    rm -rf types-finalhandler/node_modules/.cache types-finalhandler/.nyc_output
    rm ./node_modules/.cache
    rm types-finalhandler/node_modules/.cache
    rm ./node_modules/.cache
    unlink node_modules/@types/finalhandler
    dh_clean
    debian/rules binary
    dh binary
    dh_update_autotools_config
    dh_autoreconf
    dh_auto_configure --buildsystem=nodejs
    Link node_modules/@types/finalhandler -> ../../types-finalhandler
    dh_auto_build --buildsystem=nodejs
    No build command found, searching known files
    No build command found, searching known files
    dh_auto_test --buildsystem=nodejs
    ln -s ../. node_modules/finalhandler
    /bin/sh -ex debian/tests/pkg-js/test
    + mocha --reporter spec --bail --check-leaks test/


    finalhandler(req, res)
    headers
    undefined should ignore err.headers without status code
    undefined should ignore err.headers with invalid res.status
    undefined should ignore err.headers with invalid res.statusCode
    undefined should include err.headers with err.status
    undefined should include err.headers with err.statusCode
    undefined should ignore err.headers when not an object
    status code
    undefined should 404 on no error
    undefined should 500 on error
    undefined should use err.statusCode
    undefined should ignore non-error err.statusCode code
    undefined should ignore non-numeric err.statusCode
    undefined should use err.status
    undefined should use err.status over err.statusCode
    undefined should set status to 500 when err.status < 400
    undefined should set status to 500 when err.status > 599
    undefined should use err.statusCode over invalid err.status
    undefined should ignore non-error err.status code
    undefined should ignore non-numeric err.status
    status message
    undefined should be "Not Found" on no error
    undefined should be "Internal Server Error" on error
    undefined should be "Bad Request" when err.statusCode = 400
    undefined should reset existing res.statusMessage
    404 response
    undefined should include method and pathname
    undefined should escape method and pathname characters
    1) should encode bad pathname characters


    24 passing (74ms)
    1 failing

    1) finalhandler(req, res)
    404 response
    should encode bad pathname characters:

    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

    400 !== 404

    + expected - actual

    -400
    +404

    at IncomingMessage.onend (test/support/utils.js:79:20)
    at IncomingMessage.emit (node:events:536:35)
    at endReadableNT (node:internal/streams/readable:1698:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)



    dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 1 make: *** [debian/rules:8: binary] Error 25
    dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 --------------------------------------------------------------------------------

    The above is just how the build ends and not necessarily the most relevant part.
    If required, the full build log is available here:

    https://people.debian.org/~sanvila/build-logs/202505/

    About the archive rebuild: The build was made on virtual machines from AWS, using sbuild and a reduced chroot with only build-essential packages.

    If you could not reproduce the bug please contact me privately, as I
    am willing to provide ssh access to a virtual machine where the bug is
    fully reproducible.

    If this is really a bug in one of the build-depends, please use
    reassign and add an affects on src:node-finalhandler, so that this is still visible in the BTS web page for this package.

    Thanks.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Sun May 25 18:20:01 2025
    Processing control commands:

    tag -1 pending
    Bug #1106429 [src:node-finalhandler] node-finalhandler: FTBFS: test "should encode bad pathname characters" fails
    Added tag(s) pending.

    --
    1106429: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1106429
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Yadd@21:1/5 to All on Sun May 25 18:20:02 2025
    Control: tag -1 pending

    Hello,

    Bug #1106429 in node-finalhandler reported by you has been fixed in the
    Git repository and is awaiting an upload. You can see the commit
    message below and you can check the diff of the fix at:

    https://salsa.debian.org/js-team/node-finalhandler/-/commit/86197b46c6ac721d7ed288a3b818a74487bcdd7c

    ------------------------------------------------------------------------
    Drop one unstable test

    Closes: #1106429 ------------------------------------------------------------------------

    (this message was generated automatically)
    --
    Greetings

    https://bugs.debian.org/1106429

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Sun May 25 18:50:01 2025
    This is a multi-part message in MIME format...

    Your message dated Sun, 25 May 2025 16:47:02 +0000
    with message-id <E1uJEV4-004w12-En@fasolo.debian.org>
    and subject line Bug#1106429: fixed in node-finalhandler 1.2.0+~1.1.1-3
    has caused the Debian Bug report #1106429,
    regarding node-finalhandler: FTBFS: test "should encode bad pathname characters" fails
    to be marked as done.

    This means that you claim that the problem has been dealt with.
    If this is not the case it is now your responsibility to reopen the
    Bug report if necessary, and/or fix the problem forthwith.

    (NB: If you are a system administrator and have no idea what this
    message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
    immediately.)


    --
    1106429: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1106429
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    Received: (at submit) by bugs.debian.org; 24 May 2025 16:39:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
    (2021-04-09) on buxtehude.debian.org
    X-Spam-Level:
    X-Spam-Status: No, score=-121.5 required=4.0 tests=ALL_TRUSTED,BAYES_00,
    BODY_INCLUDES_PACKAGE,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,
    DKIM_VALID_AU,DKIM_VALID_EF,FROMDEVELOPER,HAS_PACKAGE,SPF_HELO_PASS,
    SPF_NONE,USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST,X_DEBBUGS_CC
    autolearn=ham autolearn_force=no
    version=3.4.6-bugs.debian.org_2005_01_02
    X-Spam-Bayes: score:0.0000 Tokens: new, 36; hammy, 150; neutral, 159; spammy,
    0. spammytokens: hammytokens:0.000-+--trixie, 0.000-+--sk:dh_auto,
    0.000-+--H*F:U*sanvila, 0.000-+--H*rp:U*sanvila, 0.000-+--buildsystem Return-path: <sanvila@debian.org>
    Received: from mailly.debian.org ([2001:41b8:202:deb:6564:a62:52c3:4