1. Forum
  2. Usenet
  3. LINUX.DEBIAN.BUGS.DIST

  • Bug#1102647: ethtool should not be user uninstallable via GUI

    From asciiwolf@seznam.cz@21:1/5 to All on Fri Apr 11 14:40:01 2025
    XPost: linux.debian.kernel

    Package: ethtool
    Version: 1:6.14-1

    ethtool is user uninstallable via GUI (such as GNOME Software or KDE Discover). This is not correct since it is a (in many configurations pre-installed) system tool, not user app, and uninstalling it can also uninstall other critical system packages.

    The main problem is the "desktop" component type in AppStream metadata:

    $ head org.kernel.software.network.ethtool.metainfo.xml
    <?xml version="1.0" encoding="UTF-8"?>
    <component type="desktop">
    <id>org.kernel.software.network.ethtool</id>
    <metadata_license>MIT</metadata_license>
    <name>ethtool</name>
    <summary>display or change Ethernet device settings</summary>
    <description>
    <p>ethtool can be used to query and change settings such as speed,
    auto- negotiation and checksum offload on many network devices,
    especially Ethernet devices.</p>

    The correct component type should be "console-application".

    (This should ideally be fixed in upstream as well.)

    Alternative solution would be removing the whole metainfo file.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From asciiwolf@seznam.cz@21:1/5 to All on Fri Apr 11 15:10:01 2025
  • From Petter Reinholdtsen@21:1/5 to All on Wed Apr 23 08:30:01 2025
    XPost: linux.debian.kernel

    Control: tags -1 + patch

    A good patch fixing this is available from
    <URL: https://lore.kernel.org/netdev/CAB-mu-TgZ5ewRzn45Q5LrGtEKWGhrafP39enmV0DAYvTkU5mwQ@mail.gmail.com/ >:

    --- org.kernel.software.network.ethtool.metainfo.xml_orig
    2025-03-31 00:46:03.000000000 +0200
    +++ org.kernel.software.network.ethtool.metainfo.xml 2025-04-11 22:14:11.634355310 +0200
    @@ -1,5 +1,5 @@
    <?xml version="1.0" encoding="UTF-8"?>
    -<component type="desktop">
    +<component type="console-application">
    <id>org.kernel.software.network.ethtool</id>
    <metadata_license>MIT</metadata_license>
    <name>ethtool</name>
    @@ -11,6 +11,7 @@
    </description>
    <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
    <provides>
    + <binary>ethtool</binary>
    <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
    </provides>
    </component>

    It should fix the issues reported on
    <URL: https://appstream.debian.org/sid/main/issues/ethtool.html >.

    --
    Happy hacking
    Petter Reinholdtsen

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Salvatore Bonaccorso@21:1/5 to Petter Reinholdtsen on Wed Apr 23 10:40:01 2025
    XPost: linux.debian.kernel

    Hi,

    On Wed, Apr 23, 2025 at 08:23:56AM +0200, Petter Reinholdtsen wrote:
    Control: tags -1 + patch

    A good patch fixing this is available from
    <URL: https://lore.kernel.org/netdev/CAB-mu-TgZ5ewRzn45Q5LrGtEKWGhrafP39enmV0DAYvTkU5mwQ@mail.gmail.com/ >:

    Yes, aware of this, but waiting until it get accepted upstream and
    then cherry-pick it from there.

    Regards,
    Salvatore

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Petter Reinholdtsen@21:1/5 to All on Wed Apr 23 10:50:01 2025
    XPost: linux.debian.kernel

    [Salvatore Bonaccorso]
    Yes, aware of this, but waiting until it get accepted upstream and
    then cherry-pick it from there.

    Very good. Then I will assume you take action in time of the
    freeze if the upstream acceptance do not make it early enough. :)

    --
    Happy hacking
    Petter Reinholdtsen

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)