Those all look like rounding errors (probably due to x87 excess
precision, since they only happen on i386). This suggests that the
appropriate response is either to ignore these tests on i386, or
possibly (the graph object output by gdf_to_nx has (x: float, y: float)
node keys, so rounding issues can potentially break retrieving
individual nodes/edges) to remove this package on i386.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mon, Apr 21, 2025 at 09:17:55PM +0100, Rebecca N. Palmer wrote:

Those all look like rounding errors (probably due to x87 excess
precision, since they only happen on i386). This suggests that the >appropriate response is either to ignore these tests on i386, or
possibly (the graph object output by gdf_to_nx has (x: float, y:
float) node keys, so rounding issues can potentially break retrieving >individual nodes/edges) to remove this package on i386.

It can't really be removed on i386, since it's Architecture: all.

--
Colin Watson (he/him) [cjwatson@debian.org]

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Tue, Apr 22, 2025 at 12:11:27PM +0200, Gregor Riepl wrote:

Those all look like rounding errors (probably due to x87 excess
precision, since they only happen on i386). This suggests that the >>appropriate response is either to ignore these tests on i386, or
possibly (the graph object output by gdf_to_nx has (x: float, y:
float) node keys, so rounding issues can potentially break
retrieving individual nodes/edges) to remove this package on i386.

Your assessment of the situation is very likely correct, since the errors are very small.

The (IMHO) correct fix should be to replace all exact comparisons with approximative ones. I don't think subtle precision errors warrant removal of the package on i386, since this a very common and well-known issue of floating point math.

Agreed.

I proposed https://github.com/pysal/momepy/pull/698 upstream to fix two
out of the three tests, and https://salsa.debian.org/openstack-team/third-party/python-momepy/-/merge_requests/1
to cherry-pick that patch into Debian and to skip the third test.
Thomas, could you have a look, please?

Thanks,

--
Colin Watson (he/him) [cjwatson@debian.org]

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

CgpPbiBBcHIgMjIsIDIwMjUgMTg6NTcsIENvbGluIFdhdHNvbiA8Y2p3YXRzb25AZGViaWFuLm9y Zz4gd3JvdGU6Cgo+Cgo+IE9uIE1vbiwgQXByIDIxLCAyMDI1IGF0IDA5OjE3OjU1UE0gKzAxMDAs IFJlYmVjY2EgTi4gUGFsbWVyIHdyb3RlOiAKCj4gPlRob3NlIGFsbCBsb29rIGxpa2Ugcm91bmRp bmcgZXJyb3JzIChwcm9iYWJseSBkdWUgdG8geDg3IGV4Y2VzcyAKCj4gPnByZWNpc2lvbiwgc2lu Y2UgdGhleSBvbmx5IGhhcHBlbiBvbiBpMzg2KS4gIFRoaXMgc3VnZ2VzdHMgdGhhdCB0aGUgCgo+ ID5hcHByb3ByaWF0ZSByZXNwb25zZSBpcyBlaXRoZXIgdG8gaWdub3JlIHRoZXNlIHRlc3RzIG9u IGkzODYsIG9yIAoKPiA+cG9zc2libHkgKHRoZSBncmFwaCBvYmplY3Qgb3V0cHV0IGJ5IGdkZl90 b19ueCBoYXMgKHg6IGZsb2F0LCB5OiAKCj4gPmZsb2F0KSBub2RlIGtleXMsIHNvIHJvdW5kaW5n IGlzc3VlcyBjYW4gcG90ZW50aWFsbHkgYnJlYWsgcmV0cmlldmluZyAKCj4gPmluZGl2aWR1YWwg bm9kZXMvZWRnZXMpIHRvIHJlbW92ZSB0aGlzIHBhY2thZ2Ugb24gaTM4Ni4gCgo+Cgo+IEl0IGNh bid0IHJlYWxseSBiZSByZW1vdmVkIG9uIGkzODYsIHNpbmNlIGl0J3MgQXJjaGl0ZWN0dXJlOiBh bGwuIAoKCkRvd25ncmFkaW5nIHRoZSBidWcgdG8gd2lzaGxpc3QgYW5kIGRpc2FibGluZyBhdXRv cGtndGVzdCBmb3IgMzIgYml0cyBpcyBwb3NzaWJsZSB0aG91Z2guCgoKVGhvbWFzIEdvaXJhbmQg KHppZ28pCgoK PGh0bWw+PGJvZHk+PGJyPjxkaXYgZGlyPSJsdHIiPk9uIEFwciAyMiwgMjAyNSAxODo1NywgQ29s aW4gV2F0c29uICZsdDtjandhdHNvbkBkZWJpYW4ub3JnJmd0OyB3cm90ZTo8L2Rpdj4KPGRpdiBk aXI9Imx0ciI+Jmd0OzwvZGl2Pgo8ZGl2IGRpcj0ibHRyIj4mZ3Q7IE9uIE1vbiwgQXByIDIxLCAy MDI1IGF0IDA5OjE3OjU1UE0gKzAxMDAsIFJlYmVjY2EgTi4gUGFsbWVyIHdyb3RlOiA8L2Rpdj4K PGRpdiBkaXI9Imx0ciI+Jmd0OyAmZ3Q7VGhvc2UgYWxsIGxvb2sgbGlrZSByb3VuZGluZyBlcnJv cnMgKHByb2JhYmx5IGR1ZSB0byB4ODcgZXhjZXNzIDwvZGl2Pgo8ZGl2IGRpcj0ibHRyIj4mZ3Q7 ICZndDtwcmVjaXNpb24sIHNpbmNlIHRoZXkgb25seSBoYXBwZW4gb24gaTM4NikuwqAgVGhpcyBz dWdnZXN0cyB0aGF0IHRoZSA8L2Rpdj4KPGRpdiBkaXI9Imx0ciI+Jmd0OyAmZ3Q7YXBwcm9wcmlh dGUgcmVzcG9uc2UgaXMgZWl0aGVyIHRvIGlnbm9yZSB0aGVzZSB0ZXN0cyBvbiBpMzg2LCBvciA8 L2Rpdj4KPGRpdiBkaXI9Imx0ciI+Jmd0OyAmZ3Q7cG9zc2libHkgKHRoZSBncmFwaCBvYmplY3Qg b3V0cHV0IGJ5IGdkZl90b19ueCBoYXMgKHg6IGZsb2F0LCB5OiA8L2Rpdj4KPGRpdiBkaXI9Imx0 ciI+Jmd0OyAmZ3Q7ZmxvYXQpIG5vZGUga2V5cywgc28gcm91bmRpbmcgaXNzdWVzIGNhbiBwb3Rl bnRpYWxseSBicmVhayByZXRyaWV2aW5nIDwvZGl2Pgo8ZGl2IGRpcj0ibHRyIj4mZ3Q7ICZndDtp bmRpdmlkdWFsIG5vZGVzL2VkZ2VzKSB0byByZW1vdmUgdGhpcyBwYWNrYWdlIG9uIGkzODYuIDwv ZGl2Pgo8ZGl2IGRpcj0ibHRyIj4mZ3Q7PC9kaXY+CjxkaXYgZGlyPSJsdHIiPiZndDsgSXQgY2Fu JiMzOTt0IHJlYWxseSBiZSByZW1vdmVkIG9uIGkzODYsIHNpbmNlIGl0JiMzOTtzIEFyY2hpdGVj dHVyZTogYWxsLiA8L2Rpdj4KPGJyPjxkaXYgZGlyPSJsdHIiPkRvd25ncmFkaW5nIHRoZSBidWcg dG8gd2lzaGxpc3QgYW5kIGRpc2FibGluZyBhdXRvcGtndGVzdCBmb3IgMzIgYml0cyBpcyBwb3Nz aWJsZSB0aG91Z2guPC9kaXY+Cjxicj48ZGl2IGRpcj0ibHRyIj5UaG9tYXMgR29pcmFuZCAoemln byk8L2Rpdj4KPGJyPjwvYm9keT48L2h0bWw+

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Tue, Apr 22, 2025 at 07:51:39PM +0800, thomas@goirand.fr wrote:

Downgrading the bug to wishlist and disabling autopkgtest for 32 bits is possible though.

You already disabled autopkgtest for 32-bit architectures in 0.7.0-3.
This is an FTBFS report, not an autopkgtest failure report.

Anyway, I already sent a patch, which hopefully you can apply.

--
Colin Watson (he/him) [cjwatson@debian.org]

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)