• Bug#1107190: unblock: debianutils/5.23

    From Ben Hutchings@21:1/5 to All on Mon Jun 2 21:20:02 2025
    XPost: linux.debian.devel.release

    This is a multi-part MIME message sent by reportbug.


    Package: release.debian.org
    Severity: normal
    X-Debbugs-Cc: debianutils@packages.debian.org, Niels Thykier <niels@thykier.net>
    Control: affects -1 + src:debianutils
    User: release.debian.org@packages.debian.org
    Usertags: unblock

    I'm requesting pre-approval for an update to debianutils.

    [ Reason ]
    Change the installkernel command (used by the kernel's "make install"
    target) to support hooks under /usr/share/kernel/postinst.d.

    [ Impact ]
    Support for kernel installation and removal hooks under
    /usr/share/kernel (as well as the currently supported /etc/kernel) has
    been implemented in the upstream kernel ("make deb-pkg" target) and
    linux-base. However, the "make install" target runs the installkernel
    command which currently runs hooks in /etc/kernel/postinst.d only.

    If we don't include this in trixie then nothing will be able to depend
    on it until forky+1.

    [ Tests ]
    I manually tested running "make install" with various combinations of
    hook scripts.

    [ Risks ]
    This is essentially the same as what the other implementations do, but
    even simpler because it doesn't need to work with older versions of
    run-parts (as it is in the same package). There is also a autopkgtest
    for run-parts that covers exactly what installkernel will do. So I
    think the risk here is very low.

    [ Checklist ]
    [X] all changes are documented in the d/changelog
    [X] I reviewed all changes and I approve them
    [X] attach debdiff against the package in testing

    [ Other info ]

    unblock debianutils/5.23

    diff --git a/debian/changelog b/debian/changelog
    index 872c4c6..560c98c 100644
    --- a/debian/changelog
    +++ b/debian/changelog
    @@ -1,3 +1,10 @@
    +debianutils (5.23) UNRELEASED; urgency=medium
    +
    + * installkernel: Add support for hooks under /usr/share/kernel/postinst.d
    + (Closes: #1107113)
    +
    + -- Ben Hutchings <benh@debian.org> Sun, 01 Jun 2025 20:17:41 +0200
    +
    debianutils (5.22) unstable; urgency=medium

    [Bastian Blank]
    diff --git a/installkernel b/installkernel
    index 7e65405..199663c 100644
    --- a/installkernel
    +++ b/installkernel
    @@ -86,7 +86,7 @@ fi
    if [ "$dir" = "/boot" ]; then
    PATH="$PATH:/usr/sbin:/sbin" \
    run-parts --verbose --exit-on-error --arg="$ver" --arg="$dir/$img_dest-$ver" \
    - /etc/kernel/postinst.d
    + /etc/kernel/postinst.d /usr/share/kernel/postinst.d
    fi

    exit 0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sebastian Ramacher@21:1/5 to Ben Hutchings on Tue Jun 3 21:20:01 2025
    XPost: linux.debian.devel.release

    Control: tags -1 confirmed

    On 2025-06-02 21:16:58 +0200, Ben Hutchings wrote:
    Package: release.debian.org
    Severity: normal
    X-Debbugs-Cc: debianutils@packages.debian.org, Niels Thykier <niels@thykier.net>
    Control: affects -1 + src:debianutils
    User: release.debian.org@packages.debian.org
    Usertags: unblock

    I'm requesting pre-approval for an update to debianutils.

    Please go ahead.

    Cheers


    [ Reason ]
    Change the installkernel command (used by the kernel's "make install"
    target) to support hooks under /usr/share/kernel/postinst.d.

    [ Impact ]
    Support for kernel installation and removal hooks under
    /usr/share/kernel (as well as the currently supported /etc/kernel) has
    been implemented in the upstream kernel ("make deb-pkg" target) and linux-base. However, the "make install" target runs the installkernel command which currently runs hooks in /etc/kernel/postinst.d only.

    If we don't include this in trixie then nothing will be able to depend
    on it until forky+1.

    [ Tests ]
    I manually tested running "make install" with various combinations of
    hook scripts.

    [ Risks ]
    This is essentially the same as what the other implementations do, but
    even simpler because it doesn't need to work with older versions of
    run-parts (as it is in the same package). There is also a autopkgtest
    for run-parts that covers exactly what installkernel will do. So I
    think the risk here is very low.

    [ Checklist ]
    [X] all changes are documented in the d/changelog
    [X] I reviewed all changes and I approve them
    [X] attach debdiff against the package in testing

    [ Other info ]

    unblock debianutils/5.23

    diff --git a/debian/changelog b/debian/changelog
    index 872c4c6..560c98c 100644
    --- a/debian/changelog
    +++ b/debian/changelog
    @@ -1,3 +1,10 @@
    +debianutils (5.23) UNRELEASED; urgency=medium
    +
    + * installkernel: Add support for hooks under /usr/share/kernel/postinst.d + (Closes: #1107113)
    +
    + -- Ben Hutchings <benh@debian.org> Sun, 01 Jun 2025 20:17:41 +0200
    +
    debianutils (5.22) unstable; urgency=medium

    [Bastian Blank]
    diff --git a/installkernel b/installkernel
    index 7e65405..199663c 100644
    --- a/installkernel
    +++ b/installkernel
    @@ -86,7 +86,7 @@ fi
    if [ "$dir" = "/boot" ]; then
    PATH="$PATH:/usr/sbin:/sbin" \
    run-parts --verbose --exit-on-error --arg="$ver" --arg="$dir/$img_dest-$ver" \
    - /etc/kernel/postinst.d
    + /etc/kernel/postinst.d /usr/share/kernel/postinst.d
    fi

    exit 0


    --
    Sebastian Ramacher

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)