In a recent long thread on debian-devel you had somewhat negative
sentiments towards the usefulness of Salsa. I do see you doing good
technical work for Debian and recently a MR from Bill too, so I was
thinking that maybe you will change your mind when you read more
in-depth arguments. This is my attempt to have you think about Salsa
in a new light:
On Tue, 9 Apr 2024 at 11:41, Bill Allombert <ballombe@debian.org> wrote:
Having a repository on salsa or even "packaging team" does not prevent
a lack of maintainer, so this is not relevant.
Without a maintainer, no contribution will be merged in any case.
Consider this Merge Request to fix debbugs builds immediately, and to
include Salsa-CI to keep the build from regressing again: https://salsa.debian.org/debbugs-team/debbugs/-/merge_requests/19
1. If the package was not on git and Salsa, I would have no way to see
what the maintainers have been doing in the years 2018-2023 (Debian
repos had last upload in 2018)
2. If the package was not on Salsa, and had the MR feature active, I
would not be able to submit a MR to fix the issues. Now the MR is up
there, and anybody can review and comment it - thus we are not even
dependent on the original maintainers alone.
3. The UI is easy and useful. I invite you to read my MR and add your
review. I made have some extra instructions to make this very
welcoming for people who do not "like" Salsa/GitLab and might feel
that something is unintuitive
4. If you don't want to use the web UI, you can also download my patch https://salsa.debian.org/debbugs-team/debbugs/-/merge_requests/19.patch
and review by email. Or you can click in the UI once to subscribe the
MR and then continue review/comments by email.
Personally I fully agree with the people stating that "Salsa is the
best thing in Debian in the past 20 years". So far everyone I talked
to who initially had reservations regarding using Salsa have started
liking it after they learned a bit more how it works, and have seen
things like Salsa-CI in action saving the Debian archive from needless widespread failures.
In this discussion about mandating things, I've been wondering....
On 19-05-2024 9:11 a.m., Jonas Smedegaard wrote:
* mandate VCS-tracking
* Yes
* mandate the use of one specific VCS
* Yes: git
What do people think this should mean, a *should* or *must* in policy?
That the package has a RC bug if the packaging isn't tracked in git? And
if the packaging is in git but I forgot to push my latest changes to the documented git server (this happens regularly to me as I do most uploads
with dgit)? RC? In all suites where the packaging version isn't pushed
for? And how about NMU's? (I just checked a random package without git: aspell-am, last non-NMU upload was in 2013)?
If *must* and thus RC, can the issue be fixed by "NMU"? I.e. if the
person that did the changes, (and has nice local commits) somehow isn't available, will the package (if not key) be auto-removed? Or can
everybody fix the repo? What if you don't have write access to the
existing repo? And then what if the uploader comes back and tries to
push the real history? What if my harddisk with local changes crashes
before I push (again, I forget that sometimes, but for me luckily dgit
will mostly have the commits).
Or is this "just a bug", maybe even at level important, but no other consequences. Than I think this discussion is going to be moot. I don't think there's much forcing possible and I think most already agree that stuff *should* be in VCS, so this isn't going to change for those in
favor. And does it really add enough value if those that are forced are
just going to do "gbp import-dsc" for each upload to the archive on a ./debian only repository? Because that (or better) we could already
automate (see also my PS).
PS: I've always wondered if the dgit server shouldn't track history,
even if uploads don't happen via it. A dgit clone could (should?)
already provide available history, even if no upload happened via it yet.
* Jonas Smedegaard: " Re: Salsa - best thing in Debian in recent years? (Re:
finally end single-person maintainership)" (Sun, 19 May 2024 10:47:38 +0200):
i.e. you are being
asocial if you don't, and can expect your behavior being discussed as a public-wide issue for the project).
I very much agree with all what you say, however could we rather say instead
i.e. you are not being collaborator friendly, and can expect your behavior befrowned upon...
I am not a native english speaker, I think we can avoid to trap in a can of worms with problematic terms like 'asocial, unsocial, anti-social...' which could have quite special meanings in different cultures.
i.e. you are being
asocial if you don't, and can expect your behavior being discussed as a public-wide issue for the project).
i.e. you are not being collaborator friendly, and can expect your behavior befrowned upon...
Hi Bill and Wookey!
In a recent long thread on debian-devel you had somewhat negative
sentiments towards the usefulness of Salsa.
I do see you doing good
technical work for Debian and recently a MR from Bill too, so I was
thinking that maybe you will change your mind when you read more
in-depth arguments. This is my attempt to have you think about Salsa
in a new light:
On Tue, 9 Apr 2024 at 11:41, Bill Allombert <ballombe@debian.org> wrote:
Having a repository on salsa or even "packaging team" does not prevent
a lack of maintainer, so this is not relevant.
Without a maintainer, no contribution will be merged in any case.
Consider this Merge Request to fix debbugs builds immediately, and to
include Salsa-CI to keep the build from regressing again: https://salsa.debian.org/debbugs-team/debbugs/-/merge_requests/19
My concern about Gitlab is not its *additions* to existing services, but its *duplications* of core services already in Debian.
I agree, that's the key problem.
...instead of lumping all those discussions into a discussion of ease of user interface for a single catch-all code forge that maybe make all those other complications go away by affecting all those questions and that way implicitly provides *some* answer to them all.
Also, there is a difference between ease of use and intuitivity. GitLab
does not provide any tools that really make packaging easier. It is
initially more accessible to non-maintainers, because of familiarity,
but actual work happens outside of it.
My concern about Gitlab is not its *additions* to existing services, but its *duplications* of core services already in Debian.
I agree, that's the key problem.
I agree that duplication is bad - but I disagree that use of version
control duplicates the use of the Debian archive for source code
storage, or that use of GitLab for code reviews would duplicate
Debbugs.
...instead of lumping all those discussions into a discussion of ease of user interface for a single catch-all code forge that maybe make all those
other complications go away by affecting all those questions and that way implicitly provides *some* answer to them all.
Also, there is a difference between ease of use and intuitivity. GitLab does not provide any tools that really make packaging easier. It is initially more accessible to non-maintainers, because of familiarity,
but actual work happens outside of it.
Would you be kind and try to understand the opposing viewpoint by
trying it for one day?
You could go to https://salsa.debian.org/debbugs-team/debbugs/-/merge_requests/19 and
conduct a code review?
You might discover that GitLab is useful and is not duplicating
Debbugs or anything else in Debian - it is currently the only platform
to conduct code reviews on in a way that has automatic testing and comment-response-resolved -tracking. Doing code reviews patches
attached in email does not have that.
If you try it out, and still think Salsa is bad for Debian, then I am
more willing to accept your stanze.
You could go to https://salsa.debian.org/debbugs-team/debbugs/-/merge_requests/19 and conduct a code review?
You might discover that GitLab is useful and is not duplicating
Debbugs or anything else in Debian - it is currently the only platform
to conduct code reviews on in a way that has automatic testing and comment-response-resolved -tracking. Doing code reviews patches
attached in email does not have that.
If you try it out, and still think Salsa is bad for Debian, then I am
more willing to accept your stanze.
But it *is* duplicating Debbugs: None of your valuable contributions
posted as part of your code review appears on Debbugs.
I agree that duplication is bad - but I disagree that use of version
control duplicates the use of the Debian archive for source code
storage, or that use of GitLab for code reviews would duplicate
Debbugs.
Would you be kind and try to understand the opposing viewpoint by
trying it for one day?
You could go to https://salsa.debian.org/debbugs-team/debbugs/-/merge_requests/19 and
conduct a code review?
You might discover that GitLab is useful and is not duplicating
Debbugs or anything else in Debian
to conduct code reviews on in a way that has automatic testing and comment-response-resolved -tracking. Doing code reviews patches
attached in email does not have that.
If you try it out, and still think Salsa is bad for Debian, then I am
more willing to accept your stanze.
Ideally debbugs should be made non-native so that some else could
maintain the Debian package.
I'm happy to review patches that get the 2.6 branch of debbugs in shape
where it can be released into Debian again if someone wants to take that effort. I've just assumed that anyone using that package was running
unstable or running debbugs out of git.
The Debian archive itself is a *bad* and *poor* VCS. It should be obviousMy concern about Gitlab is not its *additions* to existing services, but its *duplications* of core services already in Debian.
I agree, that's the key problem.
The Debian archive itself is a VCS, so git-maintained packaging is also a duplication, and keeping the official VCS and git synchronized is causing additional work for developers, which is why people are opposed to having it mandated.
PS: I've always wondered if the dgit server shouldn't track history, even if uploads don't happen via it. A dgit clone could (should?) already provide available history, even if no upload happened via it yet.
You could go to https://salsa.debian.org/debbugs-team/debbugs/-/merge_requests/19 and
conduct a code review?
You might discover that GitLab is useful and is not duplicating
Debbugs or anything else in Debian - it is currently the only platform
to conduct code reviews on in a way that has automatic testing and comment-response-resolved -tracking. Doing code reviews patches
attached in email does not have that.
If you try it out, and still think Salsa is bad for Debian, then I am
more willing to accept your stanze.
The Debian archive itself is a VCS, so git-maintained packaging is also a
duplication, and keeping the official VCS and git synchronized is causing
additional work for developers, which is why people are opposed to having it >> mandated.
The Debian archive itself is a *bad* and *poor* VCS. It should be obvious
in which areas it's poor, and it's bad e.g. because force pushes are
enabled, the history is periodically truncated (though there is no easy
way to get it anyway) etc.
It makes sense that some people want to replace it with a good VCS, but I agree that adding a good VCS only gives us two VCSes because replacing
will never happen.
Hi,We don't have a way to unpublish things, and force pushes I meant are
On 5/21/24 15:54, Andrey Rakhmatullin wrote:
The Debian archive itself is a VCS, so git-maintained packaging is also a duplication, and keeping the official VCS and git synchronized is causing additional work for developers, which is why people are opposed to having it
mandated.
The Debian archive itself is a *bad* and *poor* VCS. It should be obvious in which areas it's poor, and it's bad e.g. because force pushes are enabled, the history is periodically truncated (though there is no easy
way to get it anyway) etc.
All of these things are *also* explicit features. We need a way to unpublish things, and mirrors only want to keep a shallow subset.
Representing the Debian archive in git would probably look like a massive amount of submodules, because that's the only way to represent state across multiple projects without extending itSorry? I don't understand what you would use submodules for. Unless you
The Debian archive itself is a VCS, so git-maintained packaging is also a duplication, and keeping the official VCS and git synchronized is causing additional work for developers, which is why people are opposed to having it mandated.
On Tue, May 21, 2024 at 08:45:50PM +0900, Simon Richter wrote:
Hi,
On 5/21/24 15:54, Andrey Rakhmatullin wrote:
The Debian archive itself is a VCS, so git-maintained packaging is also a
duplication, and keeping the official VCS and git synchronized is causing
additional work for developers, which is why people are opposed to having it
mandated.
The Debian archive itself is a *bad* and *poor* VCS. It should be obvious in which areas it's poor, and it's bad e.g. because force pushes are enabled, the history is periodically truncated (though there is no easy way to get it anyway) etc.
All of these things are *also* explicit features. We need a way to unpublishWe don't have a way to unpublish things, and force pushes I meant are uploading things without including all previous changes, like all those
things, and mirrors only want to keep a shallow subset.
NMUs silently not included in the next maintainer uploads.
But, sure, some of the problems we have are explicitly features.
Representing the Debian archive in git would probably look like a massive amount of submodules, because that's the only way to represent state across multiple projects without extending itSorry? I don't understand what you would use submodules for. Unless you
meant literally mapping archive-as-VCS to a single literal VCS repo?
Otto> Would you be kind and try to understand the opposing viewpoint"Otto" == Otto Kekäläinen <otto@debian.org> writes:
On Sun, 19 May 2024, Bill Allombert wrote:
Also debbugs is a special case:
The debbugs Debian package (as opposed to the debbugs software) have never been
really maintained. I am actually one of the very few users of this package and I tried several times to get the maintainers to do a new upload but they
were clearly not interested.
It's more that I'm prioritizing spending my (very) limited Debian time
on keeping bugs.debian.org and debbugs itself working (and [very slowly] developing a new version of Debbugs with a more modern design in the
hopes that others will contribute.)
Sysop: | Keyop |
---|---|
Location: | Huddersfield, West Yorkshire, UK |
Users: | 546 |
Nodes: | 16 (0 / 16) |
Uptime: | 162:21:25 |
Calls: | 10,385 |
Calls today: | 2 |
Files: | 14,057 |
Messages: | 6,416,501 |