• Re: Bug#1073267: RFS: gpp/2.28-2 [ITA] -- general-purpose preprocessor

    From Bart Martens@21:1/5 to Leandro Cunha on Fri Jun 21 10:10:02 2024
    On Thu, Jun 20, 2024 at 06:32:41PM -0300, Leandro Cunha wrote:
    On Thu, Jun 20, 2024 at 6:03 PM Phil Wyett <philip.wyett@kathenas.org> wrote:
    3. Licenses check: ISSUES

    [...]
    and it is also something maintained upstream.
    [...]
    I don't really like the idea of changing what is maintained upstream,

    There might be a misunderstanding. In my understanding debian/copyright, which is maintained in Debian, needs to be modified to match the upstream files. Right?

    Cheers,
    Bart

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Soren Stoutner@21:1/5 to All on Fri Jun 21 08:28:24 2024
    Copy: leandrocunha016@gmail.com (Leandro Cunha)

    Leandro,

    First, thank you for your work on this package.

    On Friday, June 21, 2024 7:07:23 AM MST Leandro Cunha wrote:
    I quote about Lintian's error (acute-accent-in-manpage) in this part.
    There is a huge list of packages with this information and it seems to
    me that it would even be a false positive until it is validated that
    there really is a problem with this. But it seems to me that this
    would be ignored for most packages due to the huge list I see in UDD.
    See https://udd.debian.org/lintian-tag.cgi?tag=acute-accent-in-manual-page

    This is a relatively new Lintian check (originally introduced in 2020 and recently updated). There are currently a large number of packages failing. I would expect that to drop way down as newer version of those packages fix their man pages.

    If I were looking at sponsoring this package, I would not require that this lintian info tag be fixed for this release as long as you were committed to working on it for the next one.

    A review with the command below and two review tools on this file done
    last night found problems in the copyright file long before the emails
    about it were sent here. And I've already contacted the DD who
    reviewed the last change to talk about it and see if he can help me
    change it. I await responses and a new version of this file is ready
    for review. The package had undergone a license big change causing
    changes to the file in a version that was sent in 2018 and since then
    there have been no changes to the licensing updating only years as was changed for 2023 in a version from last year.
    egrep -sriA25 '(public dom|copyright)' | less

    It appears that the problem with the copyright file was missed in the previous review, which is easy to do. However, now that it has been discovered, it should be resolved before the next upload.

    This is a blocking issue that needs to be addressed before the package can be sponsored.

    --
    Soren Stoutner
    soren@debian.org
    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEEJKVN2yNUZnlcqOI+wufLJ66wtgMFAmZ1nBgACgkQwufLJ66w tgMKFw//dnpLcZ2PLm5K/b/9N748W0+hP7vcyMZ1ZNGNbbcClaB1i5gvXQUkvefH uJqgtOBtibN3vSMY9yEjWRLEzuUPwh4RYgjF6F4UnuKNfFYwGKS41BxDuWTZGXbb bPvCYeOBTK4V+jjZd6pVuBKO6Xh0lMYIOLtpxpmZQtUwn/qgvvLIMb9LmEY7Cp0I 2KGcLt3nboJ+m3SreDpbcbnq7idWZyOy2ZHXPakMND4lDmXl3TyroNmvxP9wc9z5 rr48/rL4eBElAP5p7KIRW237TS7RmlED2RIZG0DQjcZPiXaMOEwxkd9eLXyLHjwF RVXP8KnsGkgAZEWFidii4tH1Hft3wSaSqjYArx808saPPhkeMaFAxFXRRUySK78U ZI2mHa9MKFT/7o+xsiTCz+rtxM0gBBx9KpzTqSbCBaimleNsS7a86R+b7zSowUmD 7krl/2YouEn43Is456+obKdaFdmE3OLi/cfQ8ePD5lIXNdXorw3MJexpCncaRStC RD/kOR0+P7R1CLzmAEZl6C9jtVYCmpJXfnCpPJgyh5/dN2WYoQMJuthasVK2iMnd 9DHSezS3eil6iHKsKLMQFETygs8e5D0+lFIdFV76EmB+27fNbGB6GWhCyFDC/E8M A/IVdLK1CrOQHTojGT7YrDN55DAFvcWWjCjX9KS9Fbm3vXQTJ6c=
    =7xvR
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Bart Martens@21:1/5 to Leandro Cunha on Fri Jun 21 22:50:02 2024
    On Fri, Jun 21, 2024 at 11:07:23AM -0300, Leandro Cunha wrote:
    On Fri, Jun 21, 2024 at 5:08 AM Bart Martens <bartm@debian.org> wrote:

    On Thu, Jun 20, 2024 at 06:32:41PM -0300, Leandro Cunha wrote:
    On Thu, Jun 20, 2024 at 6:03 PM Phil Wyett <philip.wyett@kathenas.org> wrote:
    3. Licenses check: ISSUES

    [...]
    and it is also something maintained upstream.
    [...]
    I don't really like the idea of changing what is maintained upstream,

    There might be a misunderstanding. In my understanding debian/copyright, which
    is maintained in Debian, needs to be modified to match the upstream files. Right?

    I've already contacted the DD who
    reviewed the last change to talk about it and see if he can help me
    change it. I await responses and a new version of this file is ready
    for review.

    I had a look at f73fb5a6e805b6ee9620b4b20a144f5f92872b0d just now. I understand that you're awaiting responses. Let's do an other review after that.

    Cheers,
    Bart

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)