On Fri, Sep 16, 2022 at 3:10 PM Aaron Boxer <
boxerab@gmail.com> wrote:
On Fri, Sep 16, 2022 at 2:18 PM Adam Borowski <kilobyte@angband.pl> wrote:
On Fri, Sep 16, 2022 at 12:10:57PM -0400, Aaron Boxer wrote:
I have just pushed a new version to mentors that fixes the build on
armel
and mipsel.
https://mentors.debian.net/package/libgrokj2k/
If this could be uploaded it would be greatly appreciated !
Alas, it fails at least on riscv64, and possibly on other architectures as >> well.
While the proper way to fix these errors is -pthread, cmake doesn't handle >> it right on new glibc. Your build system looks complex, thus I'd propose
just trying to link with -latomic unconditionally. Because of --as-needed >> which is the default these days, the library won't be added on archs where >> it is not required.
Thanks. I actually found that I had inadvertently deleted these lines from
my rules file
ifneq (,$(filter $(DEB_HOST_ARCH), armel m68k mips mipsel powerpc sh4 riscv64))
export DEB_LDFLAGS_MAINT_APPEND += -Wl,--no-as-needed -latomic -Wl,--as-needed
endif
which were added last year for exactly this issue - build failure do to
lack of libatomic. (riscv64 wasn't there last year though)
let me re-submit with these lines restored.
Alrighty, the new version is now uploaded to the mentors site. Thanks for looking into this.
Aaron
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Seems that the Russian Army is no longer organized crime...
⢿⡄⠘⠷⠚⠋⠀
⠈⠳⣄⠀⠀⠀⠀
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Sep 16, 2022 at 3:10 PM Aaron Boxer <<a href="mailto:
boxerab@gmail.com">
boxerab@gmail.com</a>> wrote:<br></div><blockquote class="gmail_
quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Sep 16, 2022 at 2:18 PM Adam Borowski <<a
href="mailto:
kilobyte@angband.pl" target="_blank">
kilobyte@angband.pl</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Sep 16, 2022 at 12:10:57PM -
0400, Aaron Boxer wrote:<br>
> I have just pushed a new version to mentors that fixes the build on armel<br>
> and mipsel.<br>
> <br>
> <a href="
https://mentors.debian.net/package/libgrokj2k/" rel="noreferrer" target="_blank">
https://mentors.debian.net/package/libgrokj2k/</a><br>
> <br>
> If this could be uploaded it would be greatly appreciated !<br>
Alas, it fails at least on riscv64, and possibly on other architectures as<br> well.<br>
While the proper way to fix these errors is -pthread, cmake doesn't handle<br>
it right on new glibc. Your build system looks complex, thus I'd propose<br>
just trying to link with -latomic unconditionally. Because of --as-needed<br> which is the default these days, the library won't be added on archs where<br>
it is not required.<br></blockquote><div><br></div><div>Thanks. I actually found that I had inadvertently deleted these lines from my rules file</div><div><br></div><div>ifneq (,$(filter $(DEB_HOST_ARCH), armel m68k mips mipsel powerpc sh4 riscv64))<br>
export DEB_LDFLAGS_MAINT_APPEND += -Wl,--no-as-needed -latomic -Wl,--as-needed<br>endif<br></div><div><br></div><div><br></div><div>which were added last year for exactly this issue - build failure do to lack of libatomic. (riscv64 wasn't there last
year though)</div><div><br></div><div>let me re-submit with these lines restored.</div></div></div></blockquote><div><br></div><div><br></div><div>Alrighty, the new version is now uploaded to the mentors site. Thanks for looking into this.</div><div><br><
/div><div>Aaron </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_
quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Meow!<br>
-- <br>
⢀⣴⠾⠻⢶⣦⠀<br>
⣾⠁⢠⠒⠀⣿⡁ Seems that the Russian Army is no longer organized crime...<br>
⢿⡄⠘⠷⠚⠋⠀<br>
⠈⠳⣄⠀⠀⠀⠀<br>
</blockquote></div></div>
</blockquote></div></div>
--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)