Shouldn't the #undef in linux.h undefine DEFAULT_PCC_STRUCT_RETURN and not PCC_STATIC_STRUCT_RETURN?
And, secondly, shouldn't the comment in linux.h be corrected since
apparently linux.h and netbsd-elf.h disagree on what the SVR4 ABI
specifies how structs and unions are returned?
On Mai 28 2025, John Paul Adrian Glaubitz wrote:
Shouldn't the #undef in linux.h undefine DEFAULT_PCC_STRUCT_RETURN and not PCC_STATIC_STRUCT_RETURN?
No, they are separate target options. PCC_STATIC_STRUCT_RETURN is no
longer defined by default, so this is redundant now.
And, secondly, shouldn't the comment in linux.h be corrected since apparently linux.h and netbsd-elf.h disagree on what the SVR4 ABI
specifies how structs and unions are returned?
This is controlled by TARGET_RETURN_IN_MEMORY if
DEFAULT_PCC_STRUCT_RETURN is 0.
On 6/1/25 8:21 AM, John Paul Adrian Glaubitz wrote:
And what about the value for STACK_BOUNDARY? It seems to be 16 for many Linux targets while it's 32 for NetBSD. Is there a reason why it's 16-bit- aligned on Linux?
Regardless of differences in the values, I don't see changing them at
this point as that would be an ABI change.
I was talking about the comments, not the code since NetBSD and Linux disagree on what the SVR4 ABI claims.
On Jun 01 2025, John Paul Adrian Glaubitz wrote:
I was talking about the comments, not the code since NetBSD and Linux disagree on what the SVR4 ABI claims.
In which way?
Both NetBSD and Linux return structs differently, yet the comments in the source code claim their way is according to the m68k SVR4 specification.
On Jun 02 2025, John Paul Adrian Glaubitz wrote:
Both NetBSD and Linux return structs differently, yet the comments in the source code claim their way is according to the m68k SVR4 specification.
Where does it claim that?
On Jun 02 2025, John Paul Adrian Glaubitz wrote:
To me both statements seem to contradict each other.
How? They comment two different things.
Sysop: | Keyop |
---|---|
Location: | Huddersfield, West Yorkshire, UK |
Users: | 491 |
Nodes: | 16 (2 / 14) |
Uptime: | 123:45:09 |
Calls: | 9,687 |
Calls today: | 3 |
Files: | 13,728 |
Messages: | 6,176,908 |