• Re: Change in JSON output of screenshots.debian.net

    From Christoph Haas@21:1/5 to All on Mon Jul 29 19:50:01 2024
    Hi Raphael,

    Am 29.07.24 um 19:10 schrieb Raphael Hertzog:
    I have been getting failures from tracker.debian.org since July 22 about UpdatePackageScreenshotsTask now failing with this error:

    TypeError
    list indices must be integers or slices, not str

    I believe that https://screenshots.debian.net/json/packages used to be a dictionary with a single "packages" key (which was a list of all the packages).

    Now it looks like the top-level dictionary is gone and we directly have
    the list of packages. Is that on purpose and will it stay that way?

    I'd like to know if I have to fix tracker.debian.org, or if it's a mistake that you plan to revert in some way.

    That's definitely a mistake. I updated the code to Rails 7 and Ruby 3
    last month. And apparently my tests did not catch that. I'm going to fix
    that right away.

    PS: https://salsa.debian.org/debian/debshots still defaults to the master branch instead of main... I was first surprised to not find any recent
    change explaining this change of behaviour (until I discovered the main branch).

    Thanks for the hint. I have just switched the default branch to "main"
    and removed the old "master" branch. It shows up as expected.

    Best regards
    Christoph

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Raphael Hertzog@21:1/5 to All on Mon Jul 29 19:20:01 2024
    Hello Christoph & Paul,

    I have been getting failures from tracker.debian.org since July 22 about UpdatePackageScreenshotsTask now failing with this error:

    TypeError
    list indices must be integers or slices, not str

    I believe that https://screenshots.debian.net/json/packages used to be a dictionary with a single "packages" key (which was a list of all the
    packages).

    Now it looks like the top-level dictionary is gone and we directly have
    the list of packages. Is that on purpose and will it stay that way?

    I'd like to know if I have to fix tracker.debian.org, or if it's a mistake
    that you plan to revert in some way.

    Thank you!

    PS: https://salsa.debian.org/debian/debshots still defaults to the master branch instead of main... I was first surprised to not find any recent
    change explaining this change of behaviour (until I discovered the main branch).

    The only revelant commit seems to be https://salsa.debian.org/debian/debshots/-/commit/daa6d7c4b474c52e41e9601a50d87a5dd1d681ec
    but I fail to see how it can have this impact.
    --
    ⢀⣴⠾⠻⢶⣦⠀ Raphaël Hertzog <hertzog@debian.org>
    ⣾⠁⢠⠒⠀⣿⡁
    ⢿⡄⠘⠷⠚⠋ The Debian Handbook: https://debian-handbook.info/get/
    ⠈⠳⣄⠀⠀⠀⠀ Debian Long Term Support: https://deb.li/LTS

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)