• Bug#1100413: dpkg-source: Imprecise check for 3.0 (git) submodule exist

    From Daniel =?utf-8?Q?Gr=C3=B6ber?=@1:229/2 to All on Thu Mar 13 16:30:01 2025
    XPost: linux.debian.bugs.dist
    From: dxld@darkboxed.org

    Package: dpkg-dev
    Version: 1.21.22
    Severity: normal
    X-Debbugs-Cc: dxld@darkboxed.org

    Hi Guillem,

    I'm trying to use source/format 3.0 (git) to share a git-bundle of some WIP packaging changes with another DD.

    The package in question rubs dpkg-source the wrong way:

    dpkg-source: error: git repository yosys uses submodules; this is not yet supported

    However the packaging repo itself doesn't have submodules initialized so I don't think there is any real problem.

    Looking at Dpkg/Source/Package/V3/Git.pm the check is simply based on the presence of the .gitmodules config file.

    I believe the correct logic to check if submodules are actually in-use in
    the current repo would be to check if `git submodule status` returns
    non-empty output.

    What do you think?

    Thanks,
    --Daniel

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEV6G/FbT2+ZuJ7bKf05SBrh55rPcFAmfS+NkACgkQ05SBrh55 rPfF0g//Xa/xk5bvR8GMNEo0Y+8RkosuCr+J2XtEqGm0dOnTPSlOG8UtXNbhgoQO en+dHHqLeTL1nEy02plrWLh0gUAKR+ol1tT8SZbf3Ki9oTVIOobYBwCCJGi0shvh NIeIoxJbRVfs/OT5lLpeiZsc+ppMAvDuyujhFgo8lJ/AhWAPi2F78XasYmyoY3HF hHwPcV0H6VsdGVvCNO/PnQAqiQijOjtPBbYm/tJ2t/cl8LyabXANJAn4VSo9UtJb P4CKyn5r6jMaKUU17QMOuv354iH5cpSMrGVexR53yf8kirQkBW7dFwyk30/zTMQ8 0S8cTY7BVsdj1n1x82e64+exx8/vZg1meaBE2xVYfsQthSLeOSxGkcPQGe3YiNHl T1ndBFKyTJ+/VCbKBDynHy2Ktu+abrTB25D6u+gnePH+PSVUjA26/vVtD+ZRvk3t 8z4DaR4AleFmkhAOl1J8Agn/8lTdTa762HkVFnvlkHz4zdd7IY2PN5FcNWOu3+Cg dRDjevbZuLjEY5sLUesTWmu0bebplLkXuHzjyR1GGqlx3taZWye8L+X1jIg/8nKb w0FkTkx52JKq2fkOqTy2rSYPOaECZBHwWC3Rp1WPoIvN5Z425FOC9LHvRVTf4uN4 u7Xdw6+Z0klN8mmOFsRJBQ7bBunhZ/PElM4HBCpE7DnVGGHaFD0=
    =67hV
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)