1. Forum
  2. Usenet
  3. LINUX.DEBIAN.MAINT.DPKG

  • Re: Bug#1076932: webdis: FTBFS: src/client.h:6:10: fatal error: http_pa

    From James McCoy@21:1/5 to Santiago Vila on Fri Jul 26 19:50:01 2024
    On Wed, Jul 24, 2024 at 12:50:20PM GMT, Santiago Vila wrote:
    During a rebuild of all packages in unstable, your package failed to build:

    --------------------------------------------------------------------------------
    [...]
    debian/rules binary
    dh binary
    dh_update_autotools_config
    dh_autoreconf
    dh_auto_configure
    debian/rules override_dh_auto_build
    make[1]: Entering directory '/<<PKGBUILDDIR>>'
    dh_auto_build
    make -j2 "INSTALL=install --strip-program=true"
    make[2]: Entering directory '/<<PKGBUILDDIR>>'
    cc -c -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DMSGPACK=1 -o src/webdis.o src/webdis.c
    cc -c -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DMSGPACK=1 -o src/cmd.o src/cmd.c
    In file included from src/cmd.c:4:
    src/client.h:6:10: fatal error: http_parser.h: No such file or directory
    6 | #include "http_parser.h"
    | ^~~~~~~~~~~~~~~

    Nothing has changed in the packaging since it last successfully built,
    so I used debbisect to narrow down the problem to the dpkg 1.22.7
    upload.

    With dpkg 1.22.6, webdis builds fine because the CFLAGS that are defined
    in debian/rules (in particular the -I options) are picked up by the
    upstream build:

    make -j6 "INSTALL=install --strip-program=true"
    make[2]: Entering directory '/<<PKGBUILDDIR>>'
    cc -c -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -Isrc -Isrc/http-parser -
    DMSGPACK=1 -o src/webdis.o src/webdis.c

    However, with dpkg 1.22.7 we see a very different command being used to compile:

    make -j2 "INSTALL=install --strip-program=true"
    make[2]: Entering directory '/<<PKGBUILDDIR>>'
    cc -c -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DMSGPACK=1 -o src/webdis.o src/webdis.c

    It's missing "-Wdate-time -D_FORTIFY_SOURCE=2" and the include
    directories.

    The relevant lines from debian/rules are

    export DEB_BUILD_MAINT_OPTIONS=hardening=+bindnow
    include /usr/share/dpkg/buildflags.mk
    CFLAGS += $(CPPFLAGS)
    export CFLAGS += -Isrc -Isrc/http-parser

    Maybe this package is trying to use the dpkg-provided build flags
    incorrectly, but I've seen this pattern in a number of places.

    Cheers,
    --
    James
    GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Johannes Schauer Marin Rodrigues@1:229/2 to All on Fri Jul 26 20:50:01 2024
    XPost: linux.debian.bugs.dist
    From: josch@debian.org

    Hi James,

    Quoting James McCoy (2024-07-26 19:48:52)
    Nothing has changed in the packaging since it last successfully built, so I used debbisect to narrow down the problem to the dpkg 1.22.7 upload.

    you are now (to my knowledge) the second user of debbisect. Could you share your debbisect invocation? I'm interested in hearing how others are using it to potentially improve on its interface.

    Thanks!

    cheers, josch
    --==============R77475162240343969=MIME-Version: 1.0
    Content-Transfer-Encoding: 7bit
    Content-Description: signature
    Content-Type: application/pgp-signature; name="signature.asc"; charset="us-ascii"

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEElFhU6KL81LF4wVq58sulx4+9g+EFAmaj7toACgkQ8sulx4+9 g+FQXg/+Mt5/NGiPKgDPNdw1YK6JYss2CVKj4ce6UC1MZizJeV3F1v2CMphOjcXU zm+AVChQ38mwBCLR7/w6caa0EzBOfNz/L4xADNbwddYQ+j2qv4tU2IpjCvtzFlme giJDKD4+dzlAvcy12pM3UF34V4tQurjzUKH8dPc72xLnncf6XC4ZtYIVaADr0Asc Y/FvIVi00DeiSb3izIdX4w7tFW6bp9VwnGx5m8zu6M4cYcqm7/7x9cBULqlUiwPO r6CsUjOvvbwVKlOefOZQUuaRWted4lViMmZpsB+ylxqbk0LPNy4QXxE4FYRwr5Pi 0KFYbCcd9u2Vs2f90zxIceNPU9cY+at0itvZ/juuPUvH6LPxf2h+KPG44vv9dif+ B0XTgLT8q0J6PxjK0MLHH0R+0qc0xENEUvzJUimJ3qLMBVfC7K1/dVKnc56UEaSK SmKaKIdMd7hRlbgeCOoWEZiPyNGgAivG8MZHLMEDjA+HNILgvFUWKsCaYoi415Bi zoDvhVZ80vz1eTXr3QWYzn06ok4/42Zv1Yn6eJQpeUvqkxO+mPQiuCr+9ifqKXaG nYUdDkkS1iBaLMgCwvyQIRAAy1kwIkjy2vTyz/+5BDDPWb8lVZvQhGnWh4vswraa 5fdvFVab5Z4x5W/3WTsAskKnqyDGNyo8O7uE25z1sBXO6n5mm5g=
    =pIP5
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)
  • From James McCoy@1:229/2 to Johannes Schauer Marin Rodrigues on Fri Jul 26 21:30:01 2024
    XPost: linux.debian.bugs.dist
    From: jamessan@debian.org

    On Fri, Jul 26, 2024 at 08:45:49PM GMT, Johannes Schauer Marin Rodrigues wrote:
    Hi James,

    Quoting James McCoy (2024-07-26 19:48:52)
    Nothing has changed in the packaging since it last successfully built, so I used debbisect to narrow down the problem to the dpkg 1.22.7 upload.

    you are now (to my knowledge) the second user of debbisect. Could you share your debbisect invocation? I'm interested in hearing how others are using it to
    potentially improve on its interface.

    In this case, I just used the debbisect_buildsrc.sh example from the man
    page. I do have some fixes I'm planning to put up an MR for, though.

    Cheers,
    --
    James
    GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)