XPost: linux.debian.bugs.dist, linux.debian.devel.release
From:
carnil@debian.org
This is a multi-part MIME message sent by reportbug.
Package: release.debian.org
Severity: normal
X-Debbugs-Cc:
ethtool@packages.debian.org,
debian-kernel@lists.debian.org,
carnil@debian.org
Control: affects -1 + src:ethtool
User:
release.debian.org@packages.debian.org
Usertags: unblock
Hi Release team
I would like to request an approval for an unblock for
ethtool/1:6.14.1-1 uploaded to unstable.
Please unblock package ethtool
[ Reason ]
There is a new upstream bugfix release containing:
Version 6.14.1 - June 23, 2025
* Fix: incorrect data in appstream metainfo XML
* Fix: prevent potential null pointer dereferences
* Fix: more consistent and better parseable per lane signal info (-d)
The first change is what we cherry-picked already in 1.6.14-2, so the
debdiff will contain the dropping of our cherry-picked patch.
[ Impact ]
The impact of the inocrrect data in appstream metainfo XML is not
anymore relevant as we have the change already. But ethtool remains
potential affected by the NULL pointer dereferences and the missing
bugfix to have more consistent and better parseable per lane signal
info.
[ Tests ]
Just basic functional test.
[ Risks ]
All upstream cherry-picked changes for their v6.14.1 release on top of
v6.14.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
unblock ethtool/1:6.14.1-1
Regards,
Salvatore
diff -Nru ethtool-6.14/NEWS ethtool-6.14.1/NEWS
--- ethtool-6.14/NEWS 2025-04-07 22:26:40.000000000 +0200
+++ ethtool-6.14.1/NEWS 2025-06-23 21:24:14.000000000 +0200
@@ -1,3 +1,8 @@
+Version 6.14.1 - June 23, 2025
+ * Fix: incorrect data in appstream metainfo XML
+ * Fix: prevent potential null pointer dereferences
+ * Fix: more consistent and better parseable per lane signal info (-d)
+
Version 6.14 - April 7, 2025
* Feature: list PHYs (--show-phys)
* Feature: target a specific PHY with some commands (--phy)
diff -Nru ethtool-6.14/common.c ethtool-6.14.1/common.c
--- ethtool-6.14/common.c 2025-04-07 22:26:40.000000000 +0200
+++ ethtool-6.14.1/common.c 2025-06-23 21:24:14.000000000 +0200
@@ -233,8 +233,10 @@
u32 i;
printf("RSS hash key:\n");
- if (!hkey_size || !hkey)
+ if (!hkey_size || !hkey) {
printf("Operation not supported\n");
+ return;
+ }
for (i = 0; i < hkey_size; i++) {
if (i == (hkey_size - 1))
diff -Nru ethtool-6.14/configure.ac ethtool-6.14.1/configure.ac
--- ethtool-6.14/configure.ac 2025-04-07 2