• request commit for 6.1 too // scsi: megaraid_sas: Add flexible array me

    From Frank Reppin@21:1/5 to All on Sat Jun 10 01:10:01 2023
    Dear all,

    I've already followed the reply instructions on LKML - but it somewhat
    messed up my message there (so probably nobody knows what I'm talking
    about) - however ...

    Earlier this year you've committed

    scsi: megaraid_sas: Add flexible array member for SGLs https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=a9a3629592ab

    ... but it only made it into 6.3 at this time.

    I hereby kindly request to see this commit in LTS 6.1 too.

    Why?
    Debian Bookworm is soon to be released (RC4 at this moment) and is not
    yet aware of this issue...

    We're currently testing some new DELL servers and want to roll 'em out
    once Bookworm is released.
    Previous tests using Debian Bullseye (Kernel 5.10 based) where fine...
    but all of a sudden - with Debian Bookworm (Kernel 6.1 based) this weird
    call trace shows up in our logs - and this is hard to explain to QA ppl.

    Apart from this call trace showing up - I don't see any weird things.
    The /dev/disk/by-uuid/ thingie I wrote about in

    https://lkml.org/lkml/2023/6/9/1384

    is nonsense ofcourse - because upon further thinking about what I wrote
    it came apparent that the command I'm using does change/nullify the UUID
    I am talking about.

    Thankyou!
    Frank Reppin


    --
    43rd Law of Computing:
    Anything that can go wr
    fortune: Segmentation violation -- Core dumped

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Kees Cook@21:1/5 to Frank Reppin on Sat Jun 10 17:20:01 2023
    On June 9, 2023 3:42:12 PM PDT, Frank Reppin <frank@undermydesk.org> wrote: >Dear all,

    I've already followed the reply instructions on LKML - but it somewhat
    messed up my message there (so probably nobody knows what I'm talking about) - however ...

    Earlier this year you've committed

    scsi: megaraid_sas: Add flexible array member for SGLs >https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=a9a3629592ab

    ... but it only made it into 6.3 at this time.

    I hereby kindly request to see this commit in LTS 6.1 too.

    Sure! These requests are handled through the stable mailing list (now added to To:).

    Greg, please backport a9a3629592ab to 6.1 (and 6.2).

    Thanks!

    -Kees


    Why?
    Debian Bookworm is soon to be released (RC4 at this moment) and is not yet aware of this issue...

    We're currently testing some new DELL servers and want to roll 'em out
    once Bookworm is released.
    Previous tests using Debian Bullseye (Kernel 5.10 based) where fine...
    but all of a sudden - with Debian Bookworm (Kernel 6.1 based) this weird
    call trace shows up in our logs - and this is hard to explain to QA ppl.

    Apart from this call trace showing up - I don't see any weird things.
    The /dev/disk/by-uuid/ thingie I wrote about in

    https://lkml.org/lkml/2023/6/9/1384

    is nonsense ofcourse - because upon further thinking about what I wrote
    it came apparent that the command I'm using does change/nullify the UUID
    I am talking about.

    Thankyou!
    Frank Reppin




    --
    Kees Cook

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Greg KH@21:1/5 to Kees Cook on Sat Jun 10 17:50:01 2023
    On Sat, Jun 10, 2023 at 08:00:16AM -0700, Kees Cook wrote:
    On June 9, 2023 3:42:12 PM PDT, Frank Reppin <frank@undermydesk.org> wrote: >Dear all,

    I've already followed the reply instructions on LKML - but it somewhat >messed up my message there (so probably nobody knows what I'm talking about) - however ...

    Earlier this year you've committed

    scsi: megaraid_sas: Add flexible array member for SGLs >https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=a9a3629592ab

    ... but it only made it into 6.3 at this time.

    I hereby kindly request to see this commit in LTS 6.1 too.

    Sure! These requests are handled through the stable mailing list (now added to To:).

    Greg, please backport a9a3629592ab to 6.1 (and 6.2).

    6.2.y is long end-of-life (as shown on the front page of kernel.org), so
    now queued up for 6.1.y only.

    thanks,

    greg k-h

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Frank Reppin@21:1/5 to All on Wed Jun 14 15:20:01 2023
    Dear all,

    great - thankyou! ;)

    Just verified with 6.1.34 that the message is gone and all seems fine.

    @Ben / @Salvatore - would you please be so kind and cherry pick this
    commit for Debian Bookworm too?!

    Thankyou so much!

    cheers,
    Frank Reppin

    (couldn't unfortunately use reportbug to file this)

    --
    43rd Law of Computing:
    Anything that can go wr
    fortune: Segmentation violation -- Core dumped

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Salvatore Bonaccorso@21:1/5 to Frank Reppin on Wed Jun 14 15:50:01 2023
    Hi Frank,

    On Wed, Jun 14, 2023 at 03:02:43PM +0200, Frank Reppin wrote:
    Dear all,

    great - thankyou! ;)

    Just verified with 6.1.34 that the message is gone and all seems fine.

    @Ben / @Salvatore - would you please be so kind and cherry pick this commit for Debian Bookworm too?!

    I do not intent do cherry-pick it specifically because the next upload
    to Debian bookworm in the first point release which is upcoming will
    be at least based on 6.1.34, so the fix will be automatically
    included.

    Current work for preparing that can be followed at https://salsa.debian.org/kernel-team/linux/-/merge_requests/727

    So stay tuned for the first point release :)

    Regards,
    Salvatore

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Frank Reppin@21:1/5 to Salvatore Bonaccorso on Wed Jun 14 16:30:02 2023
    Dear Salvatore et al.,

    will do ;) Thanks!

    cheers,
    FR

    On 6/14/23 15:42, Salvatore Bonaccorso wrote:
    Hi Frank,

    On Wed, Jun 14, 2023 at 03:02:43PM +0200, Frank Reppin wrote:
    Dear all,

    great - thankyou! ;)

    Just verified with 6.1.34 that the message is gone and all seems fine.

    @Ben / @Salvatore - would you please be so kind and cherry pick this commit >> for Debian Bookworm too?!

    I do not intent do cherry-pick it specifically because the next upload
    to Debian bookworm in the first point release which is upcoming will
    be at least based on 6.1.34, so the fix will be automatically
    included.

    Current work for preparing that can be followed at https://salsa.debian.org/kernel-team/linux/-/merge_requests/727

    So stay tuned for the first point release :)

    Regards,
    Salvatore

    --
    43rd Law of Computing:
    Anything that can go wr
    fortune: Segmentation violation -- Core dumped

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)