1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • Re: [gentoo-dev] [PATCH] Add EAPI=8 support

    From Matt Turner@21:1/5 to All on Sun Apr 10 22:00:01 2022
    Subject should be prefixed with "cdrom.eclass:"

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Conrad Kostecki@21:1/5 to All on Sun Apr 10 21:30:01 2022
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>
    ---
    eclass/cdrom.eclass | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/eclass/cdrom.eclass b/eclass/cdrom.eclass
    index bae3888c6c5..81539e8560c 100644
    --- a/eclass/cdrom.eclass
    +++ b/eclass/cdrom.eclass
    @@ -1,10 +1,10 @@
    -# Copyright 1999-2021 Gentoo Authors
    +# Copyright 1999-2022 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: cdrom.eclass
    # @MAINTAINER:
    # games@gentoo.org
    -# @SUPPORTED_EAPIS: 6 7
    +# @SUPPORTED_EAPIS: 6 7 8
    # @BLURB: Functions for CD-ROM handling
    # @DESCRIPTION:
    # Acquire CD(s) for those lovely CD-based emerges. Yes, this violates
    @@ -16,7 +16,7 @@
    # The functions are generally called in src_unpack.

    case ${EAPI:-0} in
    - [67]) ;;
    + 6|7|8) ;;
    *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
    esac

    --
    2.35.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From James Le Cuirot@21:1/5 to Conrad Kostecki on Sun Apr 10 22:40:01 2022
    On Sun, 2022-04-10 at 21:22 +0200, Conrad Kostecki wrote:
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>
    ---
    eclass/cdrom.eclass | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/eclass/cdrom.eclass b/eclass/cdrom.eclass
    index bae3888c6c5..81539e8560c 100644
    --- a/eclass/cdrom.eclass
    +++ b/eclass/cdrom.eclass
    @@ -1,10 +1,10 @@
    -# Copyright 1999-2021 Gentoo Authors
    +# Copyright 1999-2022 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: cdrom.eclass
    # @MAINTAINER:
    # games@gentoo.org
    -# @SUPPORTED_EAPIS: 6 7
    +# @SUPPORTED_EAPIS: 6 7 8
    # @BLURB: Functions for CD-ROM handling
    # @DESCRIPTION:
    # Acquire CD(s) for those lovely CD-based emerges. Yes, this violates
    @@ -16,7 +16,7 @@
    # The functions are generally called in src_unpack.

    case ${EAPI:-0} in
    - [67]) ;;
    + 6|7|8) ;;
    *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
    esac

    That's fine, the commit message aside. There's nothing particularly API- specific about this eclass.

    On a sidenote, if all the consumers get bumped to EAPI 8 then we can revert 1e09cba657ccb2b8, which fixed the eclass for Bash 4.2 and 4.3, but made it a tiny bit more complex. EAPI 8 requires Bash 5.0.

    -----BEGIN PGP SIGNATURE-----

    iQJFBAABCAAvFiEEPxcZ3tkwcedKm2a8EiZBXQDdMTcFAmJTPj8RHGNoZXdpQGdl bnRvby5vcmcACgkQEiZBXQDdMTcR1Q//VW0lE2ViSV0Wj4CTKANkc5azZCSMP3z1 K8IvNSDlU22P5du2HO51CY5wtxVPKfWmh6sY6VK03uxZEQKJchKIA/F8YTt8TL+v MoFgosDgpa8XxGW8rlfN/pwx05FXRReXG/v+kOaIuHhQe6Gief6CnaLi18Nrwj73 Aby10LKRWF7TnEqz6Zt1aIrXgYmSGfPZKblI0gw15dPvi1xX6Vfxed2jhO8NqSBU aJm89DOhBMgzhJByWqyJu3WO7tkXJE65anmW1OSl64A1vncatuVktLLG46WWACmc 6H+Lb5uwZyCTJEaqEsrdRR2UiRD7qAM8DFbfwFGmF/yuEJ1OLQk0BtWEFyiq9mii SmyBV8CFm7iHp2HfYcs1UEiVbiYnLMOY6SNczcfpdRcRui0TA1F40wEBJmlNRLZj 6UiX7i0DZhMpHvGTHdborSpMs6K7bmJjrDSolIME/yVHs/nr16/+l2sGIsjq8ou4 X8kN9L9PmL9Eo8O2tFsswE0+hiWesH4UikeGEdv46OEgZBmWb6k9bOPGGtJfPxO8 VvY3CX6ZtZk11ZfvUVXd75hv2BFqXWQCgvBBZWqFpIh60jgsnPX5+WTvBZjBmN30 EsQ9IXQt8kaZqXjP9N33lMyvC4NrJLb0DZYcEgUntHTgTqfXVoxDQTWw/qGaX68q
    Y72zgVVWy2s=
    =9+sC
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)