1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • Re: [gentoo-dev] [PATCH] linux-info.eclass: Call ebegin, properly close

    From Thomas Bracht Laumann Jespersen@21:1/5 to All on Wed Apr 13 12:10:01 2022
    - einfo "Checking for suitable kernel configuration options..."
    + ebegin "Checking for suitable kernel configuration options..."

    ebegin outputs dots by itself, so the ones in the message should be
    removed.

    Good point, will fix... ...

    elif [[ ${soft_errors_count} -gt 0 ]]; then
    + eend 0
    ewarn "Please check to make sure these options are set correctly."
    ewarn "Failure to do so may cause unexpected problems."

    Shouldn't this be eend 1, given that there are errors?

    I was back and forth on this. It depends on what's meant by "soft errors" and if
    they're considered fatal or not, I think. I'll change to "eend 1" for the v2.

    -- Thomas

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Wed Apr 13 12:00:02 2022
    On Wed, 13 Apr 2022, Thomas Bracht Laumann Jespersen wrote:

    - einfo "Checking for suitable kernel configuration options..."
    + ebegin "Checking for suitable kernel configuration options..."

    ebegin outputs dots by itself, so the ones in the message should be
    removed.

    elif [[ ${soft_errors_count} -gt 0 ]]; then
    + eend 0
    ewarn "Please check to make sure these options are set correctly."
    ewarn "Failure to do so may cause unexpected problems."

    Shouldn't this be eend 1, given that there are errors?

    Ulrich

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmJWnUgPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4ucNMIAK1BvJI7+bqEJvI/1yrgp4KMtgnpEnb5S/nc Sd/dpofudTLWyfuPRBPB4Rn8CvN1ZFQmhOnCdjwEIM31qyoAN3Je8DWgGVVq5tEN yl2etxUSrXRGC29WeBKKJ9E4ul2EJGElFUDVVq0wM9G5ML+I89sTV+ihRlVt9t6d aHi6cfuohdv91KR6IapnUuRM6PAUkj9rhBFwtjtaZkxe8v+Bgx50aXBE/TpTZULT 874aE+lv6TJzp2X351g6wRv5wnXFvwWxAf6E5xb/x6HxF5erTM+mFf2Ptdzyxz7V eyj1sXZDaPIDrCI2Y32JDiy1at3cImn7g2XP/5Dtot0czc/WBdw=4iPq
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)