• [gentoo-dev] [PATCH 1/2] meson.eclass: disable PCH

    From Sam James@21:1/5 to All on Tue Apr 19 20:30:01 2022
    It's already masked and disabled in GCC and it causes a huge
    number of problems, but we need t odo this to avoid automagically
    trying to use PCH-even-once-it's-been-disabled-in-the-compiler.

    Bug: https://bugs.gentoo.org/839549
    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/meson.eclass | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    diff --git a/eclass/meson.eclass b/eclass/meson.eclass
    index c094f4683913..809cf10f8366 100644
    --- a/eclass/meson.eclass
    +++ b/eclass/meson.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 2017-2021 Gentoo Authors
    +# Copyright 2017-2022 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: meson.eclass
    @@ -323,6 +323,12 @@ meson_src_configure() {
    --build.pkg-config-path "${BUILD_PKG_CONFIG_PATH}${BUILD_PKG_CONFIG_PATH:+:}${EPREFIX}/usr/share/pkgconfig"
    --pkg-config-path "${PKG_CONFIG_PATH}${PKG_CONFIG_PATH:+:}${EPREFIX}/usr/share/pkgconfig"
    --native-file "$(_meson_create_native_file)"
    +
    + # gcc[pch] is masked in profiles due to consistent bugginess
    + # without forcing this off, some packages may fail too (like gjs,
    + # bug #839549), but in any case, we don't want to bother attempting
    + # this.
    + -Db_pch=false
    )

    if [[ -n ${EMESON_BUILDTYPE} ]]; then
    -
  • From Mike Gilbert@21:1/5 to sam@gentoo.org on Tue Apr 19 20:50:01 2022
    On Tue, Apr 19, 2022 at 2:21 PM Sam James <sam@gentoo.org> wrote:

    It's already masked and disabled in GCC and it causes a huge
    number of problems, but we need t odo this to avoid automagically
    trying to use PCH-even-once-it's-been-disabled-in-the-compiler.

    ACK on both patches.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)