Calling ebegin here makes no sense because it is likely that the called function will also generate output. This will lead to the "[ ok ]"
potentially appearing many lines later.

It also leads to nested ebegin calls, which make no sense for the same
reason.

Closes: https://bugs.gentoo.org/839585
Closes: https://bugs.gentoo.org/839588
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
---
eclass/ruby-ng.eclass | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
index f0d6c4f6f6c..c43d5b4d982 100644
--- a/eclass/ruby-ng.eclass
+++ b/eclass/ruby-ng.eclass
@@ -410,9 +410,8 @@ _ruby_invoke_environment() {
pushd "${WORKDIR}" &>/dev/null || die
fi

- ebegin "Running ${_PHASE:-${EBUILD_PHASE}} phase for $environment"
+ einfo "Running ${_PHASE:-${EBUILD_PHASE}} phase for $environment"
"$@"
- eend $?
popd &>/dev/null || die

S=${old_S}
--
2.36.1

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Sun, 2022-07-03 at 15:45 -0400, Mike Gilbert wrote:

Calling ebegin here makes no sense because it is likely that the
called
function will also generate output. This will lead to the "[ ok ]" potentially appearing many lines later.

It also leads to nested ebegin calls, which make no sense for the
same
reason.

I looked at this earlier and left this in because it makes sense to me
to do it this way conceptually. That implies that our tools should
supported nested ebegin calls and deal with multiline output, so for me
the real issue to fix is there.

Right now that support isn't there, though, and if that isn't
forthcoming soonish I have no objections to this patch if people feel
that is the better approach (for now).

Hans

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEIggVRmJzp0YePtgn2zR/k4ZU+jQFAmLKheQACgkQ2zR/k4ZU +jSY+wgAqn7mpB4Im+uXcYT3n8twgy7b2KIig7QXtbfeNsN/KK5iaD6/MdOyX3xi DA9GF271lt5cQPqjTpm2J0seN51Fae8qwPQ1xj0L4IOiqjdMdpn+w/FOACYcRbEd y463r7dIYKMMdxKPd/kK6feAqfkYs5+mINnxO/8TUu/Wh6XMYqDJZ5Ew5O/YIQkE 5QbA7Nz+DQviRBjIV1voQtxArrCgfzRwqixBNl3bpuHAbqIy5rJ8Bo0xNLZlG9Kq phawxVJr7CawSBzKsvR/JV7dZUGx6H6vKmiYz4ACXX34Oo9dmLjga3KVPLbIrB3Z yz9G0agRcI3mghZH+E9+bxPnaibFAA==
=O448
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)