1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] distutils-r1.eclass: fix typo in comment

    From =?UTF-8?q?Petr=20Van=C4=9Bk?=@21:1/5 to All on Tue Sep 20 17:20:02 2022
    Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
    ---
    eclass/distutils-r1.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
    index 60f81473c0a..27bd9207743 100644
    --- a/eclass/distutils-r1.eclass
    +++ b/eclass/distutils-r1.eclass
    @@ -728,8 +728,8 @@ esetup.py() {
    # to unmerge the package first.
    #
    # This function is not available in PEP517 mode. The eclass provides
    -# a venv-style install unconditionally therefore, and therefore it
    -# should no longer be necessary.
    +# a venv-style install unconditionally and therefore it should no longer
    +# be necessary.
    distutils_install_for_testing() {
    debug-print-function ${FUNCNAME} "${@}"

    --
    2.35.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to All on Mon Sep 26 12:10:02 2022
    On Tue, 2022-09-20 at 17:17 +0200, Petr Vaněk wrote:
    Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
    ---
    eclass/distutils-r1.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
    index 60f81473c0a..27bd9207743 100644
    --- a/eclass/distutils-r1.eclass
    +++ b/eclass/distutils-r1.eclass
    @@ -728,8 +728,8 @@ esetup.py() {
    # to unmerge the package first.
    #
    # This function is not available in PEP517 mode. The eclass provides
    -# a venv-style install unconditionally therefore, and therefore it
    -# should no longer be necessary.
    +# a venv-style install unconditionally and therefore it should no longer
    +# be necessary.
    distutils_install_for_testing() {
    debug-print-function ${FUNCNAME} "${@}"


    Thanks for the patch. While this is definitely good, I'm a bit
    reluctant to force the big cache regen for this, so I'd rather wait till
    we have some more changes in queue. I'm a bit afraid I won't remember
    about it though.

    --
    Best regards,
    Michał Górny

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)