1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] flag-o-matic.eclass: add append-time64-flags

    From Sam James@21:1/5 to All on Sun Oct 30 16:50:01 2022
    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/flag-o-matic.eclass | 13 +++++++++++++
    1 file changed, 13 insertions(+)

    diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
    index 365741a6dddf..d9149ebee4a5 100644
    --- a/eclass/flag-o-matic.eclass
    +++ b/eclass/flag-o-matic.eclass
    @@ -301,6 +301,19 @@ append-lfs-flags() {
    append-cppflags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
    }

    +# @FUNCTION: append-time64-flags
    +# @DESCRIPTION:
    +# Add flags that enable 64-bit time_t. Implies Large File Support
    +# (calls append-lfs-flags) automatically.
    +append-time64-flags() {
    + [[ $# -ne 0 ]] && die "append-lfs-flags takes no arguments"
    +
    + # time64 needs LFS
    + append-lfs-flags
    +
    + append-cppflags -D_TIME_BITS=64
    +}
    +
    # @FUNCTION: append-ldflags
    # @USAGE: <flags>
    # @DESCRIPTION:
    --
    2.38.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micka=C3=ABl_Bucas?=@21:1/5 to All on Mon Oct 31 11:40:02 2022
    Le dim. 30 oct. 2022 à 16:48, Sam James <sam@gentoo.org> a écrit :

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/flag-o-matic.eclass | 13 +++++++++++++
    1 file changed, 13 insertions(+)

    +# @FUNCTION: append-time64-flags
    +# @DESCRIPTION:
    +# Add flags that enable 64-bit time_t. Implies Large File Support
    +# (calls append-lfs-flags) automatically.

    Hello Sam

    As a simple user, can you explain to me or point me to a resource
    about the link between Large File Support and time64 configuration ?

    Thanks
    Best regards

    Mickaël Bucas

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Nov 9 07:30:01 2022
    On 31 Oct 2022, at 10:37, Mickaël Bucas <mbucas@gmail.com> wrote:

    Le dim. 30 oct. 2022 à 16:48, Sam James <sam@gentoo.org> a écrit :

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/flag-o-matic.eclass | 13 +++++++++++++
    1 file changed, 13 insertions(+)

    +# @FUNCTION: append-time64-flags
    +# @DESCRIPTION:
    +# Add flags that enable 64-bit time_t. Implies Large File Support
    +# (calls append-lfs-flags) automatically.

    Hello Sam


    Hi Mickaël,

    As a simple user, can you explain to me or point me to a resource
    about the link between Large File Support and time64 configuration ?


    This is a good question -- the answer is two-fold:
    1. glibc requires LFS to enable time64
    2. Both can involve an ABI break if an off_t or time_t for example
    are in an exposed structure, so it's best to do them at the same time.

    But I've had second thoughts about this and I want to rethink
    if we want to take this approach in the patch I sent.

    I think we may want to do a hard-switch for defaults
    instead in new profiles. I need to reflect on it a bit more.

    Plans and notes are at https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration
    if interested!

    Thanks
    Best regards


    Best,
    sam


    -----BEGIN PGP SIGNATURE-----

    iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY2tH418UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kFh4AQDtJud+AR0UOgA1rKFjAFkQXxeFCofO7NaIQKC8O9EzZwD9ELjcD+LexcUS uor5sUWgtiSDQBPG2jUHKRb11wIpVQ8=
    =OPkt
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Duncan@21:1/5 to All on Mon Nov 14 05:40:01 2022
    Sam James posted on Wed, 9 Nov 2022 06:25:38 +0000 as excerpted:

    On 31 Oct 2022, at 10:37, Mickaël Bucas <mbucas@gmail.com> wrote:

    Le dim. 30 oct. 2022 à 16:48, Sam James <sam@gentoo.org> a écrit :

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/flag-o-matic.eclass | 13 +++++++++++++
    1 file changed, 13 insertions(+)

    +# @FUNCTION: append-time64-flags
    +# @DESCRIPTION:
    +# Add flags that enable 64-bit time_t. Implies Large File Support
    +# (calls append-lfs-flags) automatically.

    As a simple user

    And as another user...

    Plans and notes are at https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration if interested!

    ... just in case anyone (else) needed to be sure, quoting from the above
    link:

    For 32-bit arches <snip>

    Obviously 64-bit arches are already fine.

    --
    Duncan - List replies preferred. No HTML msgs.
    "Every nonfree program has a lord, a master --
    and if you use the program, he is your master." Richard Stallman

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)