• [gentoo-dev] [PATCH 3/3] kernel-2.eclass: minor whitespace fixes

    From Sam James@21:1/5 to All on Sun Dec 25 20:20:01 2022
    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/kernel-2.eclass | 32 ++++++++++++++++----------------
    1 file changed, 16 insertions(+), 16 deletions(-)

    diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
    index 2cf88f0ff238..e13ed1a4f5ba 100644
    --- a/eclass/kernel-2.eclass
    +++ b/eclass/kernel-2.eclass
    @@ -22,7 +22,7 @@
    # @DESCRIPTION:
    # Utilized for 32-bit userland on ppc64.

    -# @ECLASS_VARIABLE: CKV
    +# @ECLASS_VARIABLE: CKV
    # @DEFAULT_UNSET
    # @DESCRIPTION:
    # Used as a comparison kernel version, which is used when
    @@ -187,36 +187,36 @@
    # Apply genpatches to kernel source. Provide any
    # combination of "base", "extras" or "experimental".

    -# @ECLASS_VARIABLE: KERNEL_URI
    +# @ECLASS_VARIABLE: KERNEL_URI
    # @DEFAULT_UNSET
    # @DESCRIPTION:
    # Upstream kernel src URI

    -# @ECLASS_VARIABLE: KV
    +# @ECLASS_VARIABLE: KV
    # @DEFAULT_UNSET
    # @OUTPUT_VARIABLE
    # @DESCRIPTION:
    # Kernel Version (2.6.0-gentoo/2.6.0-test11-gentoo-r1)

    -# @ECLASS_VARIABLE: KV_FULL
    +# @ECLASS_VARIABLE: KV_FULL
    # @DEFAULT_UNSET
  • From Ulrich Mueller@21:1/5 to All on Sun Dec 25 23:20:01 2022
    On Sun, 25 Dec 2022, Sam James wrote:

    - [[ $# -gt 3 ]] && die "Error in kernel-2_kernel_is(): too many parameters"
    + [[ $# -gt 3 ]] && die "Error in ${ECLASS}_${FUNCNAME}(): too many parameters"

    This might be somewhat misleading. The name of the function is just ${FUNCNAME}, I suppose? (Also, "Error in" is redundant in a die
    message.)

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmOoy1kPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uh1EIANMggFsVSqe46S7TG8SnIkkLu8vhOs4GdrYz JL+iOTVCh/nX2wPfRLr1xeLneIlQ1p8pTkgcFgwpaCP8CLVaep7ulznb/nEpZKCR FlnzY6d7nNpOBdYdWDTIH6iGx4C0jb/2Mk1x6N8AIymAGScwB48Bjq0Ff/CFU0/Q uG9xSL+Uf+uVq6XPKgH9b4ayFovKK3tjO2r6xqfCm1EgzYLe8K/G876a7R7481Ik y9zzv7JIvxt+Cvbl9PqK6le7JHXTLOkgpNnfUrAFGz5nNTwVSl1Km3Qb/OmU7lnG M38dnYTDoBqMvBv1NkYmiQwpwfyo/18poaCk9S72Zl5GidcCp2E=
    =sXUQ
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)