• [gentoo-dev] [PATCH 2/3] linux-info.eclass: use consistent style

    From Sam James@21:1/5 to All on Sun Dec 25 20:20:01 2022
    - Use Bash tests (i.e. [[ ]] instead of [ ])
    - Use consistent newlines for if/while
    - Drop unnecessary ; line terminators

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/linux-info.eclass | 142 ++++++++++++++++++---------------------
    1 file changed, 66 insertions(+), 76 deletions(-)

    diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
    index 3e64cb9457a9..308286e515c5 100644
    --- a/eclass/linux-info.eclass
    +++ b/eclass/linux-info.eclass
    @@ -140,13 +140,12 @@ KERNEL_DIR="${KERNEL_DIR:-${ROOT%/}/usr/src/linux}"
    # A read-only variable. It's a string containing the kernel object directory, will be KV_DIR unless
    # KBUILD_OUTPUT is used. This should be used for referencing .config.

    -
    # @ECLASS_VARIABLE: SKIP_KERNEL_CHECK
    # @USER_VARIABLE
    # @DEFAULT_UNSET
    # @DESCRIPTION:
    -# Do not check for kernel sources or a running kernel version
    -# Main use-case is for chroots
    +# Do not check for kernel sources or a running kernel version.
    +# Main use-case is for chroots.
    # This is a user flag and should under _no circumstances_ be set in the ebuild.
    : ${SKIP_KERNEL_CHECK:=""}

    @@ -156,8 +155,7 @@ inherit toolchain-funcs

    EXPORT_FUNCTIO
  • From Sam James@21:1/5 to All on Sun Dec 25 22:30:01 2022
    On 25 Dec 2022, at 19:17, Sam James <sam@gentoo.org> wrote:

    - Use Bash tests (i.e. [[ ]] instead of [ ])
    - Use consistent newlines for if/while
    - Drop unnecessary ; line terminators

    There's a missing ] on one line which I've fixed locally.

    -----BEGIN PGP SIGNATURE-----

    iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY6jAkl8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kHrwAP9bwYu4308rEyeCBx1Gg/y4ljfwRcvQ07wbNBuqLpuzfwEA9E+2pSXHUano l5wJti+TWRO+sqo6NwZyHiR2WeLSpgA=
    =6GeL
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)