1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH v2] distutils-r1.eclass: support nonfatal in test

    From alexey+gentoo@asokolov.org@21:1/5 to All on Fri Jan 6 01:30:01 2023
    From: Alexey Sokolov <alexey+gentoo@asokolov.org>

    Rationale:

    src_test() {
    virtx distutils-r1_src_test
    }

    If the test fails with "die", Xvfb keeps running forever; but it's
    cleaned up correctly with die -n

    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    ---
    eclass/distutils-r1.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
    index 371d52bcb7e..8896768d3ce 100644
    --- a/eclass/distutils-r1.eclass
    +++ b/eclass/distutils-r1.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2022 Gentoo Authors
    +# Copyright 1999-2023 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: distutils-r1.eclass
    @@ -1559,7 +1559,7 @@ distutils-r1_python_test() {
    esac

    if [[ ${?} -ne 0 ]]; then
    - die "Tests failed with ${EPYTHON}"
    + die -n "Tests failed with ${EPYTHON}"
    fi
    }

    --
    2.38.2

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to alexey+gentoo@asokolov.org on Fri Jan 6 15:50:01 2023
    On Fri, 2023-01-06 at 00:20 +0000, alexey+gentoo@asokolov.org wrote:
    From: Alexey Sokolov <alexey+gentoo@asokolov.org>

    Rationale:

    src_test() {
    virtx distutils-r1_src_test
    }

    If the test fails with "die", Xvfb keeps running forever; but it's
    cleaned up correctly with die -n

    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    ---
    eclass/distutils-r1.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
    index 371d52bcb7e..8896768d3ce 100644
    --- a/eclass/distutils-r1.eclass
    +++ b/eclass/distutils-r1.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2022 Gentoo Authors
    +# Copyright 1999-2023 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: distutils-r1.eclass
    @@ -1559,7 +1559,7 @@ distutils-r1_python_test() {
    esac

    if [[ ${?} -ne 0 ]]; then
    - die "Tests failed with ${EPYTHON}"
    + die -n "Tests failed with ${EPYTHON}"
    fi
    }


    LGTM. I need to think if we have any changes pending.

    --
    Best regards,
    Michał Górny

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Toralf_F=c3=b6rster?=@21:1/5 to All on Fri Jan 6 16:30:01 2023
    This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------9ZQOH3bItPqiLhGXmiJlMGnK
    Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64

    T24gMS82LzIzIDAxOjIwLCBhbGV4ZXkrZ2VudG9vQGFzb2tvbG92Lm9yZyB3cm90ZToNCj4g SWYgdGhlIHRlc3QgZmFpbHMgd2l0aCAiZGllIiwgWHZmYiBrZWVwcyBydW5uaW5nIGZvcmV2 ZXI7IGJ1dCBpdCdzDQo+IGNsZWFuZWQgdXAgY29ycmVjdGx5IHdpdGggZGllIC1uDQoNCkF0 IG15IHRpbmRlcmJveCBJIGRvIGV4cGVyaWVuY2Ugc29tZXRpbWVzIGEgcnVubmluZyBkaXJt bmdyIHByb2Nlc3MgDQpzb2xlbHkgcnVubmluZyBzaW5jZSBkYXlzLiAvbWUgd29uZGVycyBp ZiB0aGF0J3MgdGhlIHJlc3VsdCBvZiBhIHNpbWlsYXIgDQpzY2VuYXJpbz8NCg0KLS0gDQpU b3JhbGYNClBHUCAyMzIxN0RBNyA5Qjg4OEY0NQ0KDQo=

    --------------9ZQOH3bItPqiLhGXmiJlMGnK--

    -----BEGIN PGP SIGNATURE-----

    wsF5BAABCAAjFiEE4Aq096H1MGPqWQN3byNRLEwPvR0FAmO4PdEFAwAAAAAACgkQbyNRLEwPvR1c qA//W/ZmAyfBfhvCKKoNstX/YzjR56e9N4RkOfPbs3gv5K8nh0l2eY95qBdm/DAVlyA0mmou/aDl gr3dwyAzbERER5j1mvustUThRFmzYUPQLCvXO+s84IygCdm+C3/jTegV2eSp9dA87IgXPgp/ycWN Sy5F6B2SIcqWAPsFhlRir/ZwMglpI8nNqbq+TDqXpKprGyMADpYI3XZwlU/JTYpBH23tgOXXA55V x28Iv93fqwJDCCL1ahApXnjG52soR5CjzJ5CmVzg3xHkHreeyz9kDCzhaKpC3L52mv2hDArT9KLP cssUWlDhj443/B639kFJ+rONlrDc0ufQXgYjssLIHlmKwjT1m+Sx/aB5+5eaANHxy2HZowWZYMty lHeirZASHM78848uktHPcnUnamgwP/ytVY9sxRD0glgdy5YgPAsMhxCrPXy29Plj3R7kBxI21XE/ 6SRMGhLebQSXP9p9gy1Phh+sYIHaqiYOj+plieehTDKPo5RGgS6avoPG5ofx7xLn53pG008LqczN MaM7q89MtwXNrIfQ0QDxvmrqlU2Bdy13/Pv22jEuQAUoP3bPoltQPRo3NK3qDvGE3K/OPH0Hto9A IBcC3RyMiPSfDlo+4dG79KuFlQoufomQs3obSJObuIbkB3noRoN6MKvPGaOWIkxLsOdcIb5QRPz5 1kI=
    =Omuc
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to All on Fri Jan 6 17:40:01 2023
    On Fri, 2023-01-06 at 16:27 +0100, Toralf Förster wrote:
    On 1/6/23 01:20, alexey+gentoo@asokolov.org wrote:
    If the test fails with "die", Xvfb keeps running forever; but it's
    cleaned up correctly with die -n

    At my tinderbox I do experience sometimes a running dirmngr process
    solely running since days. /me wonders if that's the result of a similar scenario?


    Normally it shouldn't be happening since Portage uses PID namespace to
    kill all leftover processes.

    --
    Best regards,
    Michał Górny

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to alexey+gentoo@asokolov.org on Sat Jan 7 16:00:01 2023
    On Fri, 2023-01-06 at 00:20 +0000, alexey+gentoo@asokolov.org wrote:
    From: Alexey Sokolov <alexey+gentoo@asokolov.org>

    Rationale:

    src_test() {
    virtx distutils-r1_src_test
    }

    If the test fails with "die", Xvfb keeps running forever; but it's
    cleaned up correctly with die -n

    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    ---
    eclass/distutils-r1.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
    index 371d52bcb7e..8896768d3ce 100644
    --- a/eclass/distutils-r1.eclass
    +++ b/eclass/distutils-r1.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2022 Gentoo Authors
    +# Copyright 1999-2023 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: distutils-r1.eclass
    @@ -1559,7 +1559,7 @@ distutils-r1_python_test() {
    esac

    if [[ ${?} -ne 0 ]]; then
    - die "Tests failed with ${EPYTHON}"
    + die -n "Tests failed with ${EPYTHON}"
    fi
    }


    Merged now.

    --
    Best regards,
    Michał Górny

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Sat Jan 7 21:00:01 2023
    On 6 Jan 2023, at 16:31, Michał Górny <mgorny@gentoo.org> wrote:

    On Fri, 2023-01-06 at 16:27 +0100, Toralf Förster wrote:
    On 1/6/23 01:20, alexey+gentoo@asokolov.org wrote:
    If the test fails with "die", Xvfb keeps running forever; but it's
    cleaned up correctly with die -n

    At my tinderbox I do experience sometimes a running dirmngr process
    solely running since days. /me wonders if that's the result of a similar
    scenario?


    Normally it shouldn't be happening since Portage uses PID namespace to
    kill all leftover processes.


    Yeah, this is mainly an issue on e.g. prefix or containers.

    -----BEGIN PGP SIGNATURE-----

    iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY7nO+F8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kKblAP9Vk9TbLdGAxMaHpIWO5EH/BNndRm2T8pTm64i1LwYmggEAgFcwlVPP2oBA 8kHhZ+HnxdNpkQV3QWYTJPj2tz+DiQk=
    =xxej
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)