1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip

    From Sam James@21:1/5 to All on Mon Oct 11 07:10:01 2021
    This breaks at least ocamlopt.

    Closes: https://bugs.gentoo.org/803047
    Closes: https://bugs.gentoo.org/811315
    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/dune.eclass | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/eclass/dune.eclass b/eclass/dune.eclass
    index 02a8a870ef43e..8a6e01893932a 100644
    --- a/eclass/dune.eclass
    +++ b/eclass/dune.eclass
    @@ -28,6 +28,9 @@ esac
    # Do not complain about CFLAGS etc since ml projects do not use them.
    QA_FLAGS_IGNORED='.*'

    +# Breaks with ocamlopt
    +RESTRICT="strip"
    +
    EXPORT_FUNCTIONS src_compile src_test src_install

    RDEPEND=">=dev-lang/ocaml-4:=[ocamlopt?] dev-ml/dune:="
    --
    2.33.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Mon Oct 11 10:10:02 2021
    On Mon, 11 Oct 2021, Sam James wrote:

    +# Breaks with ocamlopt
    +RESTRICT="strip"

    Note that RESTRICT isn't accumulated across eclasses in EAPIs before 8.
    So for older EAPIs you may want to use RESTRICT+=" strip".

    Of course, this applies to the other two eclasses as well.

    Ulrich

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmFj78EPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uVs8H/Am1F0g6L3qPT0jS1+IiUYsk3NvKkOEW98O6 4XfD9yLs0MHDj4Sb3Fc2m/6brCA0YE7jdjf0CYTlK5fpGQVnsuxwVROqy11mkeXi fqW9RIwHsRiXxDYXJdUIT21nC/td8hN7q71bURvQA3OePGlTVTz5Woy1++wcKgBa E1tKpW1W2umMC7B97w1Mp3y/l/6EjQ5CkoBdcPRF8xvNv1X9M7dBAM8TnImYEgea 3o4nYQiO1v/sGYc3BQ3e2DIs5WAjN2U2KIfC27Nsejlz6PR4kvi850W25OKvLXXK 4hJt2vBOS7MYt4gvHgx+T5BJ1NsZZBLfMpYO7ZaobMof6UzmusI=
    =y0si
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Alexis Ballier@21:1/5 to Sam James on Mon Oct 11 13:20:01 2021
    On Mon, 2021-10-11 at 06:07 +0100, Sam James wrote:
    This breaks at least ocamlopt.

    Closes: https://bugs.gentoo.org/803047
    Closes: https://bugs.gentoo.org/811315
    Signed-off-by: Sam James <sam@gentoo.org>
    ---
     eclass/dune.eclass | 3 +++
     1 file changed, 3 insertions(+)

    diff --git a/eclass/dune.eclass b/eclass/dune.eclass
    index 02a8a870ef43e..8a6e01893932a 100644
    --- a/eclass/dune.eclass
    +++ b/eclass/dune.eclass
    @@ -28,6 +28,9 @@ esac
     # Do not complain about CFLAGS etc since ml projects do not use
    them.
     QA_FLAGS_IGNORED='.*'
     
    +# Breaks with ocamlopt
    +RESTRICT="strip"
    +



    err this is a terrible idea to do at such a large scale, esp. since
    nowadays you can use dostrip -x and provide proper comments as to what
    and why something breaks when stripped on a case by case basis

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)