1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • Re: [gentoo-dev] [PATCH] cmake.eclass: Remove duplicate eninja call fro

    From Sam James@21:1/5 to mgorny@gentoo.org on Wed Aug 23 09:00:01 2023
    Michał Górny <mgorny@gentoo.org> writes:

    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    ---
    eclass/cmake.eclass | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
    index fb3f9b6352be..d0f6d0b4bd91 100644
    --- a/eclass/cmake.eclass
    +++ b/eclass/cmake.eclass
    @@ -661,7 +661,6 @@ cmake_build() {
    OFF) NINJA_VERBOSE=OFF eninja "$@" ;;
    *) eninja "$@" ;;
    esac
    - eninja "$@"
    ;;
    esac

    Maybe add a `Fixes: ...`, but lgtm, thanks.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Matt Turner@21:1/5 to mgorny@gentoo.org on Wed Aug 23 16:20:01 2023
    On Wed, Aug 23, 2023 at 2:51 AM Michał Górny <mgorny@gentoo.org> wrote:

    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    ---
    eclass/cmake.eclass | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
    index fb3f9b6352be..d0f6d0b4bd91 100644
    --- a/eclass/cmake.eclass
    +++ b/eclass/cmake.eclass
    @@ -661,7 +661,6 @@ cmake_build() {
    OFF) NINJA_VERBOSE=OFF eninja "$@" ;;
    *) eninja "$@" ;;
    esac
    - eninja "$@"
    ;;
    esac

    --
    2.42.0

    Oops. Thanks. Looks good to me.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)