• [gentoo-dev] [PATCH 1/2] perl-module.eclass: set NONINTERACTIVE_TESTING

    From Sam James@21:1/5 to All on Sat Sep 16 11:50:01 2023
    See https://www.perlmonks.org/?node_id=1225311

    I did consider the others, but:
    * AUTOMATES_TESTING appears inappropriate for us, as it affects
    exit codes and might mask failures if configuration is wrong.
    * EXTENDED_TESTING is something we could consider if we had
    some way to opt-in to expensive tests.

    so just set NONINTERACTIVE_TESTING=1 for now, not the others mentioned
    in the link.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/perl-module.eclass | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
    index e2b66e3b6f7d2..83f94865e0214 100644
    --- a/eclass/perl-module.eclass
    +++ b/eclass/perl-module.eclass
    @@ -358,6 +358,13 @@ perl-module_src_test() {
    export NO_NETWORK_TESTING=1
    fi

    + # See https://www.perlmonks.org/?node_id=1225311
    + # * AUTOMATES_TESTING appears inappropriate for us, as it affects
    + # exit codes and might mask failures if configuration is wrong.
    + # * EXTENDED_TESTING is something we could consider if we had
    + # some way to opt-in to expensive tests.
    + export NONINTERACTIVE_TESTING=1
    +
    case ${EAPI} in
    7)
    ;;
    --
    2.42.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Sat Sep 16 11:50:01 2023
    Canary::Stability emits very vocal warnings about "unsupported" Perl versions even if they're fine in reality. It's not worth scaring our users over.

    See https://metacpan.org/pod/Canary::Stability#ENVIRONMENT-VARIABLES.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/perl-module.eclass | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
    index 83f94865e0214..c9b690992f22d 100644
    --- a/eclass/perl-module.eclass
    +++ b/eclass/perl-module.eclass
    @@ -220,6 +220,8 @@ perl-module_src_configure() {
    [[ -z ${pm_echovar} ]] && export PERL_MM_USE_DEFAULT=1
    # Disable ExtUtils::AutoInstall from prompting
    export PERL_EXTUTILS_AUTOINSTALL="--skipdeps"
    + # Noisy and not really appropriate to show to the user in a PM
    + export PERL_CANARY_STABILITY_DISABLE=1

    if [[ $(declare -p myconf 2>&-) != "declare -a myconf="* ]]; then
    local myconf_local=(${myconf})
    --
    2.42.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)