• [gentoo-dev] [PATCH 1/2] gnome2-utils.eclass: Make *_gdk_pixbuf_update

    From =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?@21:1/5 to All on Thu Jan 25 16:50:01 2024
    Remove the GNOME2_ECLASS_GDK_PIXBUF_LOADERS condition that required
    calling gnome2_gdk_pixbuf_savelist prior to gnome2_gdk_pixbuf_update.
    The actual list was never used, and all the ebuilds calling the function
    in Gentoo contain conditions to avoid calling the function when loaders
    are not built.

    Closes: https://bugs.gentoo.org/922500
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    ---
    eclass/gnome2-utils.eclass | 7 +------
    1 file changed, 1 insertion(+), 6 deletions(-)

    diff --git a/eclass/gnome2-utils.eclass b/eclass/gnome2-utils.eclass
    index 3a92a43e306a..bbee2a419dfc 100644
    --- a/eclass/gnome2-utils.eclass
    +++ b/eclass/gnome2-utils.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2023 Gentoo Authors
    +# Copyright 1999-2024 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: gnome2-utils.eclass
    @@ -363,11 +363,6 @@ gnome2_gdk_pixbuf_update() {
    local updater="${EROOT%/}/usr/bin/${CHOST}-gdk-pixbuf-query-loaders"
    [[ -x ${updater} ]] || updater="${EROOT%/}/usr/bin/gdk-pixbuf-query-loaders"

    - if [[ -z ${GNOME2_ECLASS_GDK_PIXBUF_LOADERS} ]]; then
    - debug-print "gdk-pixbuf loader cache does not need an update"
    - return
    - fi
    -
    if tc-is-cross-compiler ; then
    ewarn "Updating of gdk-pixbuf loader cache skipped due to cross-compilation."
    ewarn "You might want to run gdk-pixbuf-query-loaders manually on the target"
    --