1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • Re: [gentoo-dev] [PATCH 3/3] texlive-common.eclass: Use nonfatal-respec

    From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to Florian Schmaus on Thu Feb 29 15:40:01 2024
    On Thu, 2024-02-29 at 14:38 +0100, Florian Schmaus wrote:
    Signed-off-by: Florian Schmaus <flow@gentoo.org>
    ---
    eclass/texlive-common.eclass | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/eclass/texlive-common.eclass b/eclass/texlive-common.eclass index 96e962cb8027..85cdb8ff204e 100644
    --- a/eclass/texlive-common.eclass
    +++ b/eclass/texlive-common.eclass
    @@ -199,7 +199,8 @@ efmtutil-sys() {
    if has_version 'app-text/texlive-core' ; then
    if [[ -z ${ROOT} && -x "${EPREFIX}"/usr/bin/fmtutil-sys ]] ; then
    einfo "Rebuilding formats"
    - "${EPREFIX}"/usr/bin/fmtutil-sys --all &> /dev/null || die
    + "${EPREFIX}"/usr/bin/fmtutil-sys --all &> /dev/null \
    + || die -n "fmtutil-sys returned non-zero exit status ${res}"

    Put '||' at end of the line, then you won't need the redundant
    backslash.

    else
    ewarn "Cannot run fmtutil-sys for some reason."
    ewarn "Your formats might be inconsistent with your installed ${PN} version"

    --
    Best regards,
    Michał Górny


    -----BEGIN PGP SIGNATURE-----

    iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmXgls4SHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOlQEH/jShMlQhu9u52Z5WVzPg+jcryXU75Yda BxvTEt3wrGMrLcEtc5mml7kiwh6am4XIQiqAknpWFAIvKlwutwNytIkXTm8IVtpU mk6hzLyo31oZ2VZin3j7/CDvEsnqhyCB0FfRNgbpF5AScvGIS4P3UA2d1LIi8lxO nICM/Xfzs8+AC3h0LthpG3Lztd8Mxrrnh+NdHhlEKVnQ+Hlo2b4HVzNK9eG/sMuh pwIWV9jFbW6DVbXhuH985oT77aDOC3f9DWnGJSyXxbK1gluagbCs7JW1bFfg7LOF 24VH2miRJNbA8lY5+QGixeVO1wRZb3j0VKB+NCKcWDDMIKT5ezzzZO8=
    =1wm2
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Thu Feb 29 21:40:03 2024
    On Thu, 29 Feb 2024, Michał Górny wrote:

    + "${EPREFIX}"/usr/bin/fmtutil-sys --all &> /dev/null \ >> + || die -n "fmtutil-sys returned non-zero exit status ${res}"

    Put '||' at end of the line, then you won't need the redundant
    backslash.

    I don't think we have such a policy, so || at end of line or beginning
    of next line is really up to personal preference.

    Independent of this, looks like ${res} is not defined?

    Ulrich

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmXg6vsPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4u6J8IAJDz3+/o2eP+YVL6q48WqkOgyxPWNFB29IKY yu8GfTvB9PKZX79kKhW6KZmhTyTvXYmrg32mJVBDqKFaWzsZ49isKFC1OCtRYe3W HPxOKjuIQe+s4GpW80ywjBGNXWGoZABG8pLpW+ZGXEltUwktHjFF5fdmN1005PnS Cd3JwZaxE+SepyIzgOjud5iypMLKP1XqT2LIyNE34Pi1Ndv1vJVy4E83Eju3CSfQ Wl+nFvsHscFP7VfLoc3hAvcn9JE8DszjlpLNVFy0V1q7yxqGOGMY57OVRvsBJmCx tcNxksPYvpDymk7fYO6Ru22UHSGoVKj3JaQNW9a59RnMQ1XZDsk=hT9Z
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)