• [gentoo-dev] [PATCH 1/4] acct-user.eclass: make ACCT_USER_NAME writable

    From Michael Orlitzky@21:1/5 to All on Thu May 9 14:00:01 2024
    The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to
    this commit, it was also marked "readonly", preventing it from being
    changed in an ebuild. In an overlay, and combined with the package
    naming restrictions in the PMS, this has the unfortunate side effect of prohibiting some otherwise-valid usernames. We drop the "readonly" to
    allow those users to be managed (in overlays) using GLEP81 packages.

    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
    ---
    eclass/acct-user.eclass | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/eclass/acct-user.eclass b/eclass/acct-user.eclass
    index 66a4d6667888..a4fe5e9f5e34 100644
    --- a/eclass/acct-user.eclass
    +++ b/eclass/acct-user.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 2019-2023 Gentoo Authors
    +# Copyright 2019-2024 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: acct-user.eclass
    @@ -58,12 +58,11 @@ inherit user-info
    # << Eclass variables >>

    # @ECLASS_VARIABLE: ACCT_USER_NAME
    -# @INTERNAL
    # @DESCRIPTION:
    # The name of the user. This is forced to ${PN} and the policy prohibits
    -# it from being changed.
    +# it from being changed. The variable is left writable for use in overlays;
    +# package naming restrictions would prohibit some otherwise-valid usernames.
    ACCT_USER_NAME=${PN}
    -readonly ACCT_USER_NAME

    # @ECLASS_VARIABLE: ACCT_USER_ID
    # @REQUIRED
    --
    2.43.2

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gate
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to Michael Orlitzky on Thu May 9 14:10:01 2024
    On Thu, 2024-05-09 at 07:57 -0400, Michael Orlitzky wrote:
    The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to
    this commit, it was also marked "readonly", preventing it from being
    changed in an ebuild. In an overlay, and combined with the package
    naming restrictions in the PMS, this has the unfortunate side effect of prohibiting some otherwise-valid usernames. We drop the "readonly" to
    allow those users to be managed (in overlays) using GLEP81 packages.

    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
    ---
    eclass/acct-user.eclass | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/eclass/acct-user.eclass b/eclass/acct-user.eclass
    index 66a4d6667888..a4fe5e9f5e34 100644
    --- a/eclass/acct-user.eclass
    +++ b/eclass/acct-user.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 2019-2023 Gentoo Authors
    +# Copyright 2019-2024 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: acct-user.eclass
    @@ -58,12 +58,11 @@ inherit user-info
    # << Eclass variables >>

    # @ECLASS_VARIABLE: ACCT_USER_NAME
    -# @INTERNAL
    # @DESCRIPTION:
    # The name of the user. This is forced to ${PN} and the policy prohibits
    -# it from being changed.
    +# it from being changed. The variable is left writable for use in overlays; +# package naming restrictions would prohibit some otherwise-valid usernames.

    You're not following the original style (double spaces).

    ACCT_USER_NAME=${PN}
    -readonly ACCT_USER_NAME

    # @ECLASS_VARIABLE: ACCT_USER_ID
    # @REQUIRED

    --
    Best regards,
    Michał Górny


    -----BEGIN PGP SIGNATURE-----

    iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmY8uu8SHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOQdQH/2iZ55lxYmhlEtSQjbV4CJZO2vpe4BdK 3SqjaEcVIWRwjTggNtwy8lWvJPWUKczcaqjEN/knJ6FGAAsseE7az1wE1wIFPQ5d FUFX9UNrKLJfSPHBn/ZTB0YGzFvQJlRAcX3jleCma+z2czPEQ9R9n515QCawymsG JSpysaLhvcYRQL6WgtnU72+2QnpJq2zVHetZ9T3PJ9CltZ4rjqkZzcyNDOq+0tU9 RtBThLxof60x/GWv7oYS8qTd03UPP8F3hwT+faRvmBeI1uHTBTam2cPzRO/GEJCn 3kMS0zoPJtQPHMN3jv+zh/y6Ga559j93iMQX+mRPcDCR69a8+JvHOpg=
    =s8lS
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Fri May 10 08:00:01 2024
    On Thu, 09 May 2024, Michał Górny wrote:

    +# it from being changed. The variable is left writable for use in overlays; >> +# package naming restrictions would prohibit some otherwise-valid usernames.

    You're not following the original style (double spaces).

    This is less about style than about groff detecting sentence ends in the generated man page: https://www.gnu.org/software/groff/manual/groff.html.node/Sentences.html

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmY9t3UPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4ug88H/1GIP9+Gmtnipmata8BhU1wpUodzpqIzEnM7 6S7WjoKeRwMgMsYmK7HvXUdTPaLo3Fvf8voCrNOCQXwZKTPYg9Mi9GEdrI85l3dQ e7J489FfnnFKthdnYMn1iyILunsjN1tSqxunozWDV4/fAcHukJfE2Ojij6FSKlw/ iA6WYd+uVlkUpyMTCJeDRWm5Ld9O3NiMb2q1kiJUjKTEHTTFTYJen3XyCqq5EtNH oyZ+h19f5JcEOEJyTUzyIGbcFzfeEuWVMc9elhqDlTnENFtMDBm78bBKXfEnt39R moxwiLwooniq+2fap3nQ4dcHZVz0PyonS3QHMrQb2K4hLG3NNLE=CgRY
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)