1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] distutils-r1.eclasS: Switch scikit-build-core to b

    From =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?@21:1/5 to All on Tue Sep 24 08:20:01 2024
    Replace `cmake.verbose` with `build.verbose`, following the change
    in scikit-build-core 0.10.

    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    ---
    eclass/distutils-r1.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
    index 5a6ebdcede8a..53b40163c216 100644
    --- a/eclass/distutils-r1.eclass
    +++ b/eclass/distutils-r1.eclass
    @@ -1339,9 +1339,9 @@ distutils_pep517_install() {
    ninjaopts = shlex.split(os.environ["NINJAOPTS"])
    print(json.dumps({
    "build.tool-args": ninjaopts,
    + "build.verbose": True,
    "cmake.args": ";".join(sys.argv[1:]),
    "cmake.build-type": "${CMAKE_BUILD_TYPE}",
    - "cmake.verbose": True,
    "install.strip": False,
    }))
    EOF
    --
    2.46.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Petr =?utf-8?B?VmFuxJtr?=@21:1/5 to All on Tue Sep 24 09:50:01 2024
    On Tue, Sep 24, 2024 at 08:14:02AM +0200, Michał Górny wrote:
    Replace `cmake.verbose` with `build.verbose`, following the change
    in scikit-build-core 0.10.

    LGTM. There is a typo in commit subject, eclasS -> eclass.

    Petr

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to All on Wed Sep 25 06:30:01 2024
    On Tue, 2024-09-24 at 08:14 +0200, Michał Górny wrote:
    Replace `cmake.verbose` with `build.verbose`, following the change
    in scikit-build-core 0.10.

    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    ---
    eclass/distutils-r1.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
    index 5a6ebdcede8a..53b40163c216 100644
    --- a/eclass/distutils-r1.eclass
    +++ b/eclass/distutils-r1.eclass
    @@ -1339,9 +1339,9 @@ distutils_pep517_install() {
    ninjaopts = shlex.split(os.environ["NINJAOPTS"])
    print(json.dumps({
    "build.tool-args": ninjaopts,
    + "build.verbose": True,
    "cmake.args": ";".join(sys.argv[1:]),
    "cmake.build-type": "${CMAKE_BUILD_TYPE}",
    - "cmake.verbose": True,
    "install.strip": False,
    }))
    EOF

    Reverting this, since it breaks "older" packages. Upstream literally
    didn't provide any way for this to work for everyone.

    --
    Best regards,
    Michał Górny


    -----BEGIN PGP SIGNATURE-----

    iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmbzkRwSHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQO100H/RgILFWKC273Fh2l7FQC/PUDQ+uREpnC NNA+GvRkVkhwSbuXqrb5nPHHk8YDkvFcTFD87ul7HmSC3LfsP0QiG5BpNjKZeHGl LZqwqdaklXC5ryDwiWeqdtnpgvwUAdQZgc4v3gole1Dn2CCyEmkvgVaDfHrLX+No d0SS/4BL1bJY5JGrxNjBFMkcEHZMDB29MlD5vuLBvpI4xPRSDm/Z9IEPYL3ZDaCK Nh9TvT1o7T7b5YFeP4Tdw9br3reObMEQ0UOWlBVrThSm/mORArHiy1CNb1nzKDvx r0j8wz11Ux6i6jhf4c/5kvSX4oAMlMypQGHeCycGKUBKVXPhW7vXP3c=
    =0yto
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)