• [gentoo-dev] Re: [PATCH] guile-utils.eclass: set GUILE_AUTO_COMPILE=fre

    From Sam James@21:1/5 to arsen@gentoo.org on Thu Dec 26 12:10:01 2024
    Arsen Arsenović <arsen@gentoo.org> writes:

    Hi Sam,

    Sam James <sam@gentoo.org> writes:

    Noticed this when looking at app-office/gnucash which was disabling
    GUILE_AUTO_COMPILE entirely (see 72dbf2ec4049df11ad63576971883ee239eadb7f). >>
    We don't want Guile making decisions based on the system cache
    files. Always recompile so we're deterministic.

    See https://www.gnu.org/software/guile/manual/html_node/Environment-Variables.html#index-GUILE_005fAUTO_005fCOMPILE.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/guile-utils.eclass | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/eclass/guile-utils.eclass b/eclass/guile-utils.eclass
    index b0660dcfd1ce6..d066013486edc 100644
    --- a/eclass/guile-utils.eclass
    +++ b/eclass/guile-utils.eclass
    @@ -84,10 +84,14 @@ guile_check_compat
    # @FUNCTION: guile_set_common_vars
    # @DESCRIPTION:
    # Sets common variables that apply to all Guile packages, namely,
    -# QA_PREBUILT.
    +# GUILE_AUTO_COMPILE and QA_PREBUILT.
    guile_set_common_vars() {
    debug-print-function ${FUNCNAME} "$@"

    + # We don't want Guile making decisions based on the system cache
    + # files. Always recompile so we're deterministic.
    + export GUILE_AUTO_COMPILE=fresh
    +
    # These aren't strictly speaking prebuilt. but they do generated a
    # nonstandard ELF object.
    if [[ -z ${QA_PREBUILT} ]]; then

    Thanks, this is reasonable - feel free to apply (not at dev machine at
    the moment).

    Thank you, pushed!


    Happy holidays!

    You too! :)

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?utf-8?Q?Arsen_Arsenovi=C4=87?=@21:1/5 to Sam James on Thu Dec 26 11:40:01 2024
    Hi Sam,

    Sam James <sam@gentoo.org> writes:

    Noticed this when looking at app-office/gnucash which was disabling GUILE_AUTO_COMPILE entirely (see 72dbf2ec4049df11ad63576971883ee239eadb7f).

    We don't want Guile making decisions based on the system cache
    files. Always recompile so we're deterministic.

    See https://www.gnu.org/software/guile/manual/html_node/Environment-Variables.html#index-GUILE_005fAUTO_005fCOMPILE.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/guile-utils.eclass | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/eclass/guile-utils.eclass b/eclass/guile-utils.eclass
    index b0660dcfd1ce6..d066013486edc 100644
    --- a/eclass/guile-utils.eclass
    +++ b/eclass/guile-utils.eclass
    @@ -84,10 +84,14 @@ guile_check_compat
    # @FUNCTION: guile_set_common_vars
    # @DESCRIPTION:
    # Sets common variables that apply to all Guile packages, namely,
    -# QA_PREBUILT.
    +# GUILE_AUTO_COMPILE and QA_PREBUILT.
    guile_set_common_vars() {
    debug-print-function ${FUNCNAME} "$@"

    + # We don't want Guile making decisions based on the system cache
    + # files. Always recompile so we're deterministic.
    + export GUILE_AUTO_COMPILE=fresh
    +
    # These aren't strictly speaking prebuilt. but they do generated a
    # nonstandard ELF object.
    if [[ -z ${QA_PREBUILT} ]]; then

    Thanks, this is reasonable - feel free to apply (not at dev machine at
    the moment).

    Happy holidays!
    --
    Arsen Arsenović

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iIcEARYKAC8WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZ20yMREcYXJzZW5AZ2Vu dG9vLm9yZwAKCRBSwpQwHqLEk222AQDOT3M0IOqOqUgZIzvrDb6oaNQS4O1jO4HE CtNuaCD7VwD+O2jbMLnFyl3vuS9rCqQOhL/mD7ccal1Fghw46XdByAk=lF0C
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)