• [gentoo-dev] [PATCH] cmake.eclass: Avoid false positives by ensuring we

    From Andreas Sturmlechner@21:1/5 to All on Mon Jun 23 00:49:41 2025
    Otherwise the regex might pick up a query of the resulting version var, e.g.:

    if(CMAKE_MINIMUM_REQUIRED_VERSION VERSION_LESS 2.8.12)

    Bug: https://bugs.gentoo.org/958923
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
    ---
    eclass/cmake.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
    index 520ac14eec..e5f972c203 100644
    --- a/eclass/cmake.eclass
    +++ b/eclass/cmake.eclass
    @@ -253,7 +253,7 @@ _cmake_check_build_dir() {
    # Returns 0 if the regex matched (a lower-than-specified version found).
    _cmake_minreqver-lt() {
    local ver chk=1
    - ver=$(sed -ne "/cmake_minimum_required/I{s/.*\(\.\.\.*\|\s\)\([0-9][0-9.]*\)\([)]\|\s\).*$/\2/p;q}" \
    + ver=$(sed -ne "/^\s*cmake_minimum_required/I{s/.*\(\.\.\.*\|\s\)\([0-9][0-9.]*\)\([)]\|\s\).*$/\2/p;q}" \
    "${2}" 2>/dev/null \
    )
    if [[ -n ${ver} ]] && ver_test "${ver}" -lt "${1}"; then
    --
    2.50.0
    -----BEGIN PGP SIGNATURE-----

    iQITBAABCgB9FiEEmaksxp6GvcraXyZQrlkbvHPk3V4FAmhYiIVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk5 QTkyQ0M2OUU4NkJEQ0FEQTVGMjY1MEFFNTkxQkJDNzNFNERENUUACgkQrlkbvHPk 3V6/HQwAhvUbUYXaE+YLoAd5wFSCZIEePelcmPgr1DWeoIc6U8n2011t3GBy47F8
    xgABflpdvcGG