1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] skel.ebuild: update SRC_URI

    From kangie@gentoo.org@21:1/5 to All on Sat Jun 28 13:10:01 2025
    From: Matt Jolly <kangie@gentoo.org>

    In 2025 FTP is increasingly uncommon. The world we live in is (mostly)
    HTTPS, and SRC_URI should reflect that.

    Add additional commentry about (and use SRC_URI to show an example of)
    renaming the distfile with `->` when required.

    Signed-off-by: Matt Jolly <kangie@gentoo.org>
    ---
    skel.ebuild | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/skel.ebuild b/skel.ebuild
    index 437e0d5c569d..29e679528778 100644
    --- a/skel.ebuild
    +++ b/skel.ebuild
    @@ -29,8 +29,8 @@ DESCRIPTION="This is a sample skeleton ebuild file"
    HOMEPAGE="https://foo.example.org/"

    # Point to any required sources; these will be automatically downloaded by
    -# Portage.
    -SRC_URI="ftp://foo.example.org/${P}.tar.gz"
    +# Portage. If a file needs to be renamed, use the "->" syntax. +SRC_URI="https://files.example.org/foo/v${PV}.tar.xz -> ${P}.tar.xz"

    # Source directory; the dir where the sources can be found (automatically
    # unpacked) inside ${WORKDIR}. The default value for S is ${WORKDIR}/${P}
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?utf-8?Q?Ulrich_M=C3=BCller?=@21:1/5 to All on Sat Jun 28 16:20:01 2025
    On Sat, 28 Jun 2025, kangie wrote:

    -# Portage.
    -SRC_URI="ftp://foo.example.org/${P}.tar.gz"
    +# Portage. If a file needs to be renamed, use the "->" syntax. +SRC_URI="https://files.example.org/foo/v${PV}.tar.xz -> ${P}.tar.xz"

    Explaining "->" in the comment is fine, but not sure if it is a good
    idea in the actual SRC_URI example. New contributors will inevitably
    copy the line to their ebuild, even if it's not needed. (We've been
    there before, that's why "econf" and "emake" are commented out now).

    Ulrich

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmhf+UkPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4u2XsH/1MHH38cbCbTCewBr/6uji/KG9lrohmKOzgh W1C1l2+gqmfdPDQF8IpVV7snTJQOEggt7m/TaMtVcLAknFgGh4JEYahpyDq//Z2j NTasLoK1aEnOsVjxzo0pVJ0+5OKgx9BjKPWVYPgo4RT0s3EAycfHashe0HcUNknf RfjwaYln8fx4pe34d6Z7l0cu+DMiBQhMViTTkREejsVNDWbcqCo2O/4oRVJ3yqiq fwPDUpXX6sxEUGA6xBQ/grUt8ilGsZp5S93OrRRXuuIfULvDtPNBSV7vb75qdgGu zyUm8KiXsJIb0PPgFgw6pQwZvk/EDHagzaQFmuCM3Ai9Pig2vQc=
    =0Lmn
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ionen Wolkens@21:1/5 to All on Sun Jun 29 03:50:01 2025
    On Sat, Jun 28, 2025 at 04:16:41PM +0200, Ulrich Müller wrote:
    On Sat, 28 Jun 2025, kangie wrote:

    -# Portage.
    -SRC_URI="ftp://foo.example.org/${P}.tar.gz"
    +# Portage. If a file needs to be renamed, use the "->" syntax. +SRC_URI="https://files.example.org/foo/v${PV}.tar.xz -> ${P}.tar.xz"

    Explaining "->" in the comment is fine, but not sure if it is a good
    idea in the actual SRC_URI example. New contributors will inevitably
    copy the line to their ebuild, even if it's not needed. (We've been
    there before, that's why "econf" and "emake" are commented out now).

    Think I'd also prefer it be kept an example for "normal" tarballs rather
    than what is more often automated git archive with v${PV} which we'd
    rather not be used if normal tarballs exist.

    I sometime do see people do ${P}.tar.xz -> ${P}.tar.xz just because they
    copied it from somewhere too (pkgcheck can warn about that tho).

    Note wouldn't hurt, but special knowledge (->) can in general be picked
    up later when it's needed, skel.ebuild does not have cover every details
    and is just a starting guideline.
    --
    ionen

    -----BEGIN PGP SIGNATURE-----

    iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmhgmjkACgkQskQGsLCs QzReEAgAklLnWb0Cd6kqM2l7xnIN8R+BItxNz3zaNZ90ft9otGQG1sFxU4wHbIL5 G4CzzdoePDAUyU/hodlafUnaYEzrM4WszEJ7r8KgWUocOrRw/oOMt45FVHEJ+jJr 6X1RBma5qzqrarUfrFSQsMFxdsRyqCIV1/vXvo+b5KcPSGotGQECwCIZPkc5r+C5 9hSv5trXckMt3/SLjvUd9J2clna7ePE2+mK+Y6yXu0G79uH4pe08nXS933X5R556 jRwJhT9R7Zo9ymHGHAHGNP7SoZHKeqcUIOR8+zSuNJDfcTR/VS4AhUN4eS0cHJg/ pwXaZ8zQVa5sjtdBvCzgJmurGw+SLQ==
    =i6OJ
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Duncan@21:1/5 to All on Sun Jun 29 14:40:01 2025
    kangie posted on Sat, 28 Jun 2025 20:49:29 +1000 as excerpted:

    In 2025 FTP is increasingly uncommon. The world we live in is (mostly)
    HTTPS, and SRC_URI should reflect that.

    ++

    Add additional commentry about (and use SRC_URI to show an example of) renaming the distfile with `->` when required.
    # Point to any required sources; these will be automatically downloaded by -# Portage.
    -SRC_URI="ftp://foo.example.org/${P}.tar.gz"
    +# Portage. If a file needs to be renamed, use the "->" syntax. +SRC_URI="https://files.example.org/foo/v${PV}.tar.xz -> ${P}.tar.xz"

    So I suppose I'm as portage-positive as the next guy, but...

    Maybe take the opportunity to s/Portage/package manager/ (mangler?) or
    some such while you're at it? (Or maybe "EAPI compliant package manager"
    if just PM's too generic, or just PM if it's not considered to ambiguous...) Just seems a bit like tunnel vision to specifically name portage in something like skel.ebuild these days, even if portage /is/ the vast majority, user-side.

    (Of course doesn't /have/ to be /this/ commit if someone thinks that needs
    more discussion than the simple s/ftp/https/ stuff or maybe council needs
    to vote on a change like that... but the discussion would need to start somewhere even if it won't go in this commit, so...)

    --
    Duncan - List replies preferred. No HTML msgs.
    "Every nonfree program has a lord, a master --
    and if you use the program, he is your master." Richard Stallman

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From kangie@gentoo.org@21:1/5 to All on Sat Jul 5 09:10:01 2025
    From: Matt Jolly <kangie@gentoo.org>

    In 2025 FTP is increasingly uncommon. The world we live in is (mostly)
    HTTPS, and SRC_URI should reflect that.

    Add commentry about renaming distfiles with `->` when required.

    Signed-off-by: Matt Jolly <kangie@gentoo.org>
    ---
    skel.ebuild | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/skel.ebuild b/skel.ebuild
    index 437e0d5c569d..213761669a41 100644
    --- a/skel.ebuild
    +++ b/skel.ebuild
    @@ -29,8 +29,8 @@ DESCRIPTION="This is a sample skeleton ebuild file"
    HOMEPAGE="https://foo.example.org/"

    # Point to any required sources; these will be automatically downloaded by
    -# Portage.
    -SRC_URI="ftp://foo.example.org/${P}.tar.gz"
    +# Portage. If a file needs to be renamed use the "->" syntax. +SRC_URI="https://files.example.org/foo/${P}.tar.xz"

    # Source directory; the dir where the sources can be found (automatically
    # unpacked) inside ${WORKDIR}. The default value for S is ${WORKDIR}/${P}
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)